fix: Disable history nav when completions dialog is open - #50
Merged
Merged
Conversation
Contributor
|
I'll take a look in my pr as well to see if I can get this integrated further and not have two states. Thanks for the find |
bussard76
pushed a commit
to bussard76/openwork
that referenced
this pull request
May 12, 2026
* fix(windows): hide CLI console windows * refactor: modularize tauri backend * chore: fix cargo check warnings
zoulukuang
added a commit
to zoulukuang/deskfox
that referenced
this pull request
Aug 14, 2026
…diff: 单个新文件,一份不可拆的执行脚本] 新增 `run_group4.py`,覆盖 anomalyco#40~anomalyco#50,全部通过。样本由 `make_fixtures.py` 生成、内容带特征词, 所以「预览对不对」是断言出来的,不是「看着像渲染出来了」。 ## 被实测推翻的「想当然」 - **代码/文本预览渲染在 `<diffs-container>` 的 shadow DOM 里**。 `document.body.innerText` 里根本没有文件内容 —— 于是「打开 plain.txt 后搜不到 TXTMARK」 一度被误读成「代码类文件没渲染」,还去翻了 iframe、canvas、闭合 shadow。 内容一直都在,只是选择器不穿 shadow 边界。已给 uiprobe 加 `deep_find_text` / `selection_text`。 - **对已打开的文件再点一次是「收起预览」**(界面上明写着「点击可收起预览」)。 脚本连开两次同一文件 = 把预览关掉,这是上面那个「搜不到内容」的直接触发条件。 `open_tree_path` 现在会核对预览是否真开着,被收起就再点回来。 - **右键菜单项是普通 `button`,不是 `role=menuitem`**;且**空白处右键给不出菜单** —— 「添加到聊天窗口 / 复制 / 导出为 Word」是针对选区的,必须先拖选。 第一版没选就右键、又按 ARIA role 查,拿到空菜单,差点判成缺陷。 - **`.xlsx` 走 LibreOffice 分页渲染,没有 `<table>`**。第一版按「有没有 table」写, 实际 `tables=0` 却因为文本命中而报了通过 —— 是**断言写松了蒙对**,已改成 断言两个 sheet 的特征词都在(证明整本工作簿都转换了)。 - **`code/` 目录初始就是展开的**,按「先变多再变回」写的断言直接误判(17→12→17); 改成只要求两次点击一开一合、且回到原状,不假设初始态。 ## anomalyco#48 的结论:能力齐全,是条目把入口写死了 右键菜单里**只有「关闭其他标签」**;「关闭标签页」在命令面板/⌘W; 「重新打开已关闭的标签页」命令面板搜不到、`mod+shift+t` 也不响应。 去基准版 `e77443750e`(合上游前)对照:**源码里根本没有 `reopenClosed`** —— 它是上游本次**新增**的命令,注册在 `titlebar.tsx` 的 tab 条上,而 DeskFox 的标签条 不走那条渲染路径。故属「上游新功能未接入」,**不是同步弄丢了功能**,按事实记录不报 FAIL。 CHECKLIST 同步更正 anomalyco#44 / anomalyco#47 / anomalyco#48 三条的预期与工具列。 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wut6R6htBzR8fBN8gbJkWg
|
Implementado em d96fb56e0d ( eat(axiom): add daily work plan approval review flow) e publicado em dev. Entregas:
Validação:
Issue concluída. |
|
Fechando após merge em dev pelo commit d96fb56e0d. |
AlHeloween
added a commit
to AlHeloween/opencode
that referenced
this pull request
Sep 19, 2026
…ary leaves no hole Owner, 2026-09-19: «там не просто 32к нам не менее 32к и все сообщения до предыдущего summary если оно где нибудь не вызвалось надо забрать весь контент до него. Чтобы не было s..s..s xxxxx (what happened there) xxx 32k tokens?» So 32k is a floor AND the tail must be CONTIGUOUS with what the summaries represent. The boundary was the summary ROW — the summary message's own position — which is not what a summary COVERS. When a summary fires LATE, its covered range ends at anomalyco#50 while its row sits at anomalyco#80, and the messages in between are represented by NOTHING: not summarised, not in the tail. The agent then reads «s..s..s [xxxxx what happened there?] tail» and has to go and check. Now `compact()` resolves the newest COVERED message from the summaries' `toId` through the same positions map the `#N` labels use and passes it as `coveredThroughIndex`: everything after it is MANDATORY tail whatever its size, and only past it may the floor stop the walk. The summary row survives as the fallback when no summary carries a resolvable range (a fixture, a legacy summary). The Range accounting block added earlier now checks a rule the selector ENFORCES, so `no gap` is structural rather than hoped for — a GAP line would mean the selector failed, not that the renderer merely noticed. Oracle: `bun typecheck` exit 0 · compaction 87/0/250 · compact 9/0/45 · summary-cadence 29/0/55 · prompt 42 pass / 13 skip / 0 fail / 169. The new case drives the pure selector directly: a summary row at anomalyco#8 covering through anomalyco#3, where the tail must carry anomalyco#4..anomalyco#7 and the row-as-boundary variant must DROP them — both pinned. Typecheck caught what the suite could not, again: `expect(MessageID[]).toEqual(string[])` is a type error while all 87 tests passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This time I think I fixed it for real...