Conversation
The spawner resolved its exit signal on "close", which waits for stdio EOF. A descendant that outlives the process and inherits its pipes (for example a detached server, or Start-Process on Windows) keeps them open, so exitCode, kill, and scope release blocked until that descendant died. The shell tool timeout killed the shell on schedule but the call stayed blocked. Settle from "exit" after a short drain window when "close" has not fired. Fixes anomalyco#49169
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #49169
Type of change
What does this PR do?
The spawner settled process exit on
close, which waits for stdio EOF. A leftover process holding the pipes (detached server,Start-Processon Windows) means EOF never comes, soexitCode,kill()and scope cleanup blocked. The shell tool timeout killed the shell, then hung on that kill.exitnow starts a 1s timer that settles the signal ifclosehasn't fired. Side effect:sleep 8 & echo startedreturns ~1s after the shell exits instead of blocking. Likely covers #47350 too.v2already has this via #46085. This brings the same behaviour todev, which 1.18.x releases are cut from (v1.18.31 still has the bug).How did you verify your code works?
Added spawner and shell tool tests with a detached grandchild holding stdout: 8.4s on
devwithtimeout: 500, ~1s with the fix.packages/coreandpackages/opencodesuites pass on macOS. Not verified on Windows.Screenshots / recordings
N/A
Checklist