Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #49685
Type of change
What does this PR do?
packages/core/src/filesystem/search.tsimported theFileSystemself-namespace from../filesystemto callEntry.make/Match.make, creating a runtime import cycle betweenfilesystem.tsandfilesystem/search.ts. In compiled builds that cycle can leaveFileSystemSearch.nodeundefined whilefilesystem.tsbuilds its layer node, so booting a location crashes withTypeError: undefined is not an object (evaluating 'node.name')on the first prompt. Source mode happened to work because of ESM live bindings.The fix imports
Entry/Matchdirectly from@opencode-ai/schema/filesystemand makesFileSystema type-only import, removing the runtime cycle. Same values, no behavior change.How did you verify your code works?
bun run --cwd packages/core typecheckbun run --cwd packages/opencode script/build.ts --single), ranserve, sent a prompt:session.errorwith thenode.nameTypeError, assistant message never completesfinish: "stop"and streams normallyScreenshots / recordings
Not a UI change.
Checklist