Skip to content

fix(tui): surface remote auth startup errors - #49016

Merged
thdxr merged 1 commit into
devfrom
remote-auth-tui
Sep 14, 2026
Merged

thdxr merged 1 commit into
devfrom
remote-auth-tui

Conversation

@opencode-agent

@opencode-agent opencode-agent Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • return ConfigRemoteAuthError as a structured client error across the instance HTTP boundary
  • teach the existing TUI error path to render the re-login instructions
  • preserve TUI cleanup while marking fatal startup exits nonzero instead of hard-coding exit status 0
  • cover both the middleware payload and TUI lifecycle behavior

Closes #49011

Tests

  • bun test test/server/httpapi-error-middleware.test.ts (packages/opencode)
  • bun typecheck (packages/opencode)
  • bun test test/app-lifecycle.test.tsx test/util/error.test.ts (packages/tui)
  • bun typecheck (packages/tui)
  • isolated PTY reproduction: actionable auth message, no generic server error, exit status 1
  • scoped oxlint on changed files (no errors; pre-existing warnings only)

Requested by: @thdxr (dax via Slack)

ConfigRemoteAuthError was omitted from the server config-error pass-through, so TUI bootstrap lost the actionable payload. Fatal TUI startup also completed normally, forcing exit status 0.
@thdxr
thdxr enabled auto-merge (squash) September 14, 2026 17:19
@thdxr
thdxr disabled auto-merge September 14, 2026 17:24
@thdxr
thdxr merged commit a97622c into dev Sep 14, 2026
10 checks passed
@thdxr
thdxr deleted the remote-auth-tui branch September 14, 2026 17:24
hugojosefson pushed a commit to hugojosefson/opencode that referenced this pull request Sep 18, 2026
Co-authored-by: thdxr <826656+thdxr@users.noreply.github.com>
rossigee pushed a commit to rossigee/opencode that referenced this pull request Sep 18, 2026
Co-authored-by: thdxr <826656+thdxr@users.noreply.github.com>
1056674754 added a commit to 1056674754/opencode that referenced this pull request Sep 19, 2026
Upstream v1.18.30 (3104c14, merged at 16220da) -> v1.18.31 (014614d),
25 commits / 108 files. Staged delta vs pre-merge fork HEAD is identical to
the upstream tag-to-tag diff (108 files, +3425/-2146), confirming a clean
adoption.

Functional changes:
- fix(acp): restore session options and reasoning boundaries (anomalyco#48225) —
  acp/service.ts +193 lines; isolated from the fork snapshot architecture.
- fix(opencode): request summarized adaptive thinking (anomalyco#48269) — 1 line in
  github-copilot/models.ts.
- fix(tui): surface remote auth startup errors (anomalyco#49016).
- fix(ui): Merge Gateway logo (anomalyco#42015).
- chore(deps): bump @ai-sdk/gateway to 3.0.191 (anomalyco#48710) and llm package
  (11 packages installed via bun install).
- console/stats/go: route migrated Go inference, batch workspace block
  endpoints, Go billing source forwarding, DeepSeek V4.1 Flash (model +
  stats normalization + promo docs), retention sync timeout fix, GLM-5.3
  allowance docs.

Conflicts resolved: 29 package.json version bumps (rebranded 1.18.31-sscity),
bun.lock (took upstream, rebranded workspace entries via bun install). Zero
source conflicts; fork-sensitive files (transform.ts, provider.ts,
config.ts) untouched upstream in this range. Fork deltas verified intact vs
v1.18.31: ProviderSnapshot architecture (+492 in provider.ts), GLM
normalization (+77 in transform.ts), config getFresh/commitFresh (+14).
Tests: provider, transform, bedrock, config, v2, azure plugin, session
retry/llm — 1058 pass / 0 fail across 15 files; typecheck clean.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
mjmartinezsoriano pushed a commit to mjmartinezsoriano/opencode that referenced this pull request Sep 21, 2026
Co-authored-by: thdxr <826656+thdxr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expired well-known token aborts TUI startup with generic error

1 participant