test(app): retire legacy layout e2e coverage - #49015
Merged
Merged
Conversation
opencode-agent
Bot
requested review from
Brendonovich and
Hona
as code owners
September 14, 2026 16:56
dallenpyrah
pushed a commit
to Rika-Labs/opencode
that referenced
this pull request
Sep 16, 2026
Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
lihaokun
added a commit
to lihaokun/opencode
that referenced
this pull request
Sep 16, 2026
Cherry-picked verbatim from upstream 7f20943 (anomalyco#49015). Not this branch's doing, despite where it surfaced. settings.tsx sets oldInterfaceSunset to 2026-09-14, and resolveNewLayoutDesigns returns true once that date passes whatever the stored preference says, so the old layout became unreachable and the two tests that asserted it started failing on that date. This branch's first CI run happened to be the same day; dev would fail the same way today. Upstream fixed it on the day, and taking their change rather than inventing one keeps the fork from diverging over it. The legacy new-session spec goes, since the route it covered no longer exists — app.tsx says the legacy /:dir/session route is replaced by a draft at /new-session?draftId=…. The timeline spec drops its CommentStrip assertion, because the new layout renders comments inside the message rather than in a strip above it, and drops the newLayoutDesigns: false that no longer does anything.
hugojosefson
pushed a commit
to hugojosefson/opencode
that referenced
this pull request
Sep 18, 2026
Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
rossigee
pushed a commit
to rossigee/opencode
that referenced
this pull request
Sep 18, 2026
Co-authored-by: rekram1-node <rekram1-node@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommentStriprowWhy
The old interface sunset is September 14, 2026. Once CI crossed that date, settings correctly forced
newLayoutDesignson even when these tests storedfalse, so both legacy-only assertions failed deterministically on Linux and Windows.Testing
bun typecheckinpackages/appbun test src/context/settings.test.tsinpackages/appRequested by: @rekram1-node (Aiden via Slack)