Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
woodsonl
force-pushed
the
tui-continue-dummy-id
branch
2 times, most recently
from
September 8, 2026 22:06
de91ed0 to
9160c4f
Compare
woodsonl
force-pushed
the
tui-continue-dummy-id
branch
from
September 12, 2026 02:29
9160c4f to
1a5581c
Compare
--continue seeded the session route with sessionID "dummy", which the route eagerly fetched; the server rejects it because ids must start with ses_, so cold start showed "Unexpected server error". Seed an empty id and skip the fetch instead, and let the continue effect resolve the real session. Also make an explicit --session win over -c, and navigate home when -c finds no previous session instead of leaving a blank screen. Adds a regression test that fails on dev (FAST_BOOT + delayed /session response) and asserts no request is made for the placeholder id.
woodsonl
force-pushed
the
tui-continue-dummy-id
branch
from
September 14, 2026 21:58
1a5581c to
a451524
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #47556
Type of change
What does this PR do?
opencode --continueseeds the session route withsessionID: "dummy"(from #31049). The route eagerly fetches that id, and the server rejects it because session ids must start withses_, so a cold start shows "Unexpected server error". WithOPENCODE_FAST_BOOT=1the route mounts before the continue effect runs, so it fails reliably.This PR seeds an empty id instead and skips the eager fetch when empty, so no request fires for the placeholder; the continue effect still resolves the real id and navigates. It also makes an explicit
--sessionwin over-cwhen both are passed, and navigates home instead of showing a blank screen when-chas no previous session.How did you verify your code works?
Added
packages/tui/test/app-lifecycle.test.tsx: pinsOPENCODE_FAST_BOOT=1, delays the/sessionresponse, and asserts no request goes to/session/dummyand the eventual fetch targets the real session id. Confirmed the test fails ondevand passes here. Full tui suite (194 tests) andbun run typecheckpass.Checklist