Repository navigation
fix(provider): skip Bedrock cache point below minimum cacheable size - #45842
jangraviren wants to merge 1 commit into
Conversation
AWS Bedrock rejects a cachePoint when the cached prefix is below the model's minimum cacheable size (~1024 tokens for Claude) with HTTP 400 "There is nothing available to cache. Please remove the invalid cache point and try again." — unlike the Anthropic API, which silently ignores an undersized cache_control. A short context (e.g. the first turn of a freshly forked session) would otherwise fail outright. Guard applyCaching() so the Bedrock cache point is only added once the prompt clears the minimum, using the existing Token.estimate helper. Updates existing bedrock caching tests to use realistically-sized prompts and adds a dedicated 'minimum cacheable size' suite.
github-actions
Bot
added
needs:compliance
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
the
needs:compliance
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
2 participants
Issue for this PR
Closes #45855
Type of change
What does this PR do?
applyCaching()always adds a BedrockcachePoint. Bedrock rejects a cache point when the cached prefix is under the model's minimum (~1024 tokens for Claude) with a 400, so a short prompt — like the first turn of a freshly forked session — fails outright instead of just running uncached. (The Anthropic API tolerates this; Bedrock doesn't.)The fix guards the Bedrock branch: estimate the prompt size with the existing
Token.estimate, and skip the cache point below ~1024 tokens. Other providers are untouched.How did you verify your code works?
bun test test/provider/transform.test.ts→ 427 pass, 0 fail.I updated the existing Bedrock caching tests to use prompts above the minimum (they assert the caching wiring), fixed one reasoning-replay test that used a tiny prompt, and added a small suite asserting: undersized prompt → no cache point, large enough prompt → cache point present.
Note: repo-wide
typecheckfails on a pre-existing error insrc/bus/global.tsthat this PR doesn't touch;transform.tstypechecks clean.Screenshots / recordings
N/A — no UI change.
Checklist