Skip to content

feat(app): add Hebrew (he) locale - #45205

Closed
Lev-Good wants to merge 2 commits into
anomalyco:devfrom
Lev-Good:feat/i18n-hebrew-locale
Closed

Lev-Good wants to merge 2 commits into
anomalyco:devfrom
Lev-Good:feat/i18n-hebrew-locale

Conversation

@Lev-Good

@Lev-Good Lev-Good commented Aug 26, 2026 •

Copy link
Copy Markdown

Issue for this PR

Closes #42447 (feature request for Hebrew locale)

Type of change

  • New feature

What does this PR do?

Adds Hebrew (he) support across the app, ui, and desktop packages:

  • Registers he in DESKTOP_NATIVE_LOCALES / labels / tags (desktop-native.ts) and in the desktop renderer i18n (renderer/i18n/index.ts)
  • Adds he to the RTL_LOCALES set in language.tsx so Hebrew renders right-to-left
  • Adds he to the i18n parity tests (parity.test.ts, desktop-native.test.ts)
  • Adds full Hebrew dictionaries: packages/app/src/i18n/he.ts, packages/ui/src/i18n/he.ts, packages/desktop/src/renderer/i18n/he.ts
  • Adds a Hebrew translation glossary for the translation agent: .opencode/glossary/he.md

Hebrew plural variants (.two) follow Intl.PluralRules("he-IL") categories (one, two, other).

Supersedes #39423 (stale Hebrew PR with merge conflicts since July; the author did not respond). All work here is rebased on the latest dev with no conflicts.

How did you verify your code works?

  • The i18n parity tests and desktop-native tests pass locally under Bun (parity.test.ts, desktop-native.test.ts): every English key covered, no unexpected extras, placeholders preserved, required plural variants present
  • The branch is rebased on the latest upstream dev with no conflicts

Screenshots / recordings

N/A (language support, no UI screenshots)

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Add Hebrew translation dictionaries for app, ui, and desktop packages,
register `he` in the desktop native locales and RTL set, and cover it
in the i18n parity tests.

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate Found

PR #39423: feat(i18n): Add Hebrew language support with RTL handling

This appears to be a duplicate of the current PR #45205. Both PRs are adding Hebrew (he) locale support with RTL handling. You should check if PR #39423 is still open and whether it addresses the same feature request (#42447) or if one supersedes the other.

Add translation guidance for Hebrew: preferred terms, RTL handling,
and the plural-form rules (one/two/other) used by the parity tests.

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Add Hebrew (he) locale

1 participant