feat(plugin): add session.stopping hook for loop continuation - #44712
Open
orenbaldinger wants to merge 1 commit into
Open
orenbaldinger wants to merge 1 commit into
orenbaldinger wants to merge 1 commit into
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16626
Type of change
What does this PR do?
Adds an awaited
session.stoppingplugin hook in theHooksinterface to allow external plugins to evaluate session state and optionally inject a continuation message before the prompt loop breaks.Key semantics:
SessionPrompt.runimmediately prior to natural loop exit.stop: true. If a plugin listener throws or rejects, execution stops cleanly (stop: true,message: undefined).stop: true, subsequent listeners cannot force continuation.SESSION_STOPPING_REENTRY_CAP = 3to prevent runaway infinite loops from misconfigured plugins.session.deleted.How did you verify your code works?
bun test packages/opencode/test/plugin/session-stopping.test.ts(listener ordering, error isolation, fail-closed behavior)bun test --timeout 30000 packages/opencode/test/plugin/session-stopping-exit-matrix.test.ts(compaction stops, provider/tool error non-natural exits, nested sessions, concurrent loop callers)bun turbo typecheckacross all workspace packagesScreenshots / recordings
N/A — backend lifecycle hook change without UI modifications.
Checklist