Repository navigation
docs(keybinds): document missing keybinds - #44675
harshil-mistry wants to merge 1 commit into
Conversation
32 keybinds defined in Definitions were absent from the reference block, including the whole diff viewer set and the session quick-switch slots. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Heads up on this entry: |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #44673
Type of change
What does this PR do?
Adds the 32 keybinds that were defined in
Definitionsbut missing from thetui.jsonreference block on the keybinds page. The page listed 152 of 184.The block reads as the complete set of defaults, so anything absent from it is effectively invisible — the diff viewer was the worst case, since all 16 of its binds were missing even though most have real defaults (
escape,q,enter,space,],[,n,p,?and so on). Also added were the ninesession_quick_switch_*slots,session_background,session_pin_toggle,session_queued_prompts,debug_view, and the threedialog.move_session.*binds.Every value is copied from
Definitionsrather than invented, and I inserted each key in the same position it occupies there, so the block still reads in the same order as the source.No existing lines are modified — the diff is purely additive.
How did you verify your code works?
Docs-only, so I verified it by comparison rather than by running anything:
tui.jsonblock out of the page with a JSON parser and diffed itskeybindskeys against the keys inDefinitions. Before: 152 documented against 184 defined, 32 missing. After: 184 against 184, nothing missing and nothing documented that doesn't exist.keybind(...)default. Zero mismatches, both before and after — confirming the existing entries were already correct and I didn't disturb them.A reviewer can re-run that comparison against
packages/tui/src/config/keybind.ts.One thing worth flagging separately, since it's out of scope here: on
v2these IDs were renamed to dot notation in #41882, so that branch's copy of this page is stale in a different way. I've left it alone as it isn't what deploys today.Screenshots / recordings
Not a UI change.
Checklist