Skip to content

docs(keybinds): document missing keybinds - #44675

Closed
harshil-mistry wants to merge 1 commit into
anomalyco:devfrom
harshil-mistry:docs-missing-keybinds
Closed

harshil-mistry wants to merge 1 commit into
anomalyco:devfrom
harshil-mistry:docs-missing-keybinds

Conversation

@harshil-mistry

Copy link
Copy Markdown

Issue for this PR

Closes #44673

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Adds the 32 keybinds that were defined in Definitions but missing from the tui.json reference block on the keybinds page. The page listed 152 of 184.

The block reads as the complete set of defaults, so anything absent from it is effectively invisible — the diff viewer was the worst case, since all 16 of its binds were missing even though most have real defaults (escape,q, enter,space, ], [, n, p, ? and so on). Also added were the nine session_quick_switch_* slots, session_background, session_pin_toggle, session_queued_prompts, debug_view, and the three dialog.move_session.* binds.

Every value is copied from Definitions rather than invented, and I inserted each key in the same position it occupies there, so the block still reads in the same order as the source.

No existing lines are modified — the diff is purely additive.

How did you verify your code works?

Docs-only, so I verified it by comparison rather than by running anything:

  • Parsed the tui.json block out of the page with a JSON parser and diffed its keybinds keys against the keys in Definitions. Before: 152 documented against 184 defined, 32 missing. After: 184 against 184, nothing missing and nothing documented that doesn't exist.
  • Compared the documented value of every shared key against its keybind(...) default. Zero mismatches, both before and after — confirming the existing entries were already correct and I didn't disturb them.
  • Confirmed the block still parses as valid JSON after the edit.

A reviewer can re-run that comparison against packages/tui/src/config/keybind.ts.

One thing worth flagging separately, since it's out of scope here: on v2 these IDs were renamed to dot notation in #41882, so that branch's copy of this page is stale in a different way. I've left it alone as it isn't what deploys today.

Screenshots / recordings

Not a UI change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

32 keybinds defined in Definitions were absent from the reference block,
including the whole diff viewer set and the session quick-switch slots.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@hawkxdev

Copy link
Copy Markdown

Heads up on this entry: session_queued_prompts ("Manage queued prompts", default <leader>q) has no handler in the fullscreen TUI. The manager is only implemented in the --mini client (packages/opencode/src/cli/cmd/run/footer.view.tsx); the shared registry defines the binding at packages/tui/src/config/keybind.ts:102 (checked dev @ ebb7b76e). On 1.18.31, with a non-empty queue and the composer focused, ctrl+x q with empty input exits the app (app_exit binds the same chord, line 48), and with text in the composer the q falls through into the input buffer. Might be worth an availability note on this entry, or skipping it here.

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keybinds docs are missing 32 of the 184 defined keybinds

2 participants