fix(core): stop bash hanging after process exit

[yyueniao]

Issue for this PR

Closes #20902
Closes #25038
Closes #28697
Closes #36342
Closes #37838
Closes #42044
Closes #42524

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

Process exit should work same as stdio close so either one can finish the bash command.

How did you verify your code works?

Automated tests:

cd packages/core && bun test test/effect/cross-spawn-spawner.test.ts
cd packages/opencode && bun test test/tool/shell.test.ts -t "grandchild"

Manual: cd packages/opencode && bun dev, then run:

node -e 'const {spawn}=require("node:child_process");const c=spawn("sleep",["3600"],{stdio:"inherit",detached:true});c.unref();console.log("done")'

Before: see done, but opencode hang and tool never completes.
After: tool returns immediately.

Screenshots / recordings

N/A

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Potential related PRs found:

1. fix(core): resolve child process exit signal on exit event #42275: fix(core): resolve child process exit signal on exit event

   • Related to handling child process exit signals, similar domain to the current PR

2. fix(core): resolve spawn completion on exit, not only close (Windows detached-child hang) #29831: fix(core): resolve spawn completion on exit, not only close (Windows detached-child hang)

   • Directly related—addresses the same issue of process hanging due to exit vs. close events. This appears to be a previous attempt or related fix for detached child process hangs.

Why they're related: Both PRs address process completion signaling (exit vs. close events) to prevent subprocess hangs, particularly with detached processes. PR #29831 specifically mentions "Windows detached-child hang" which is the same class of issue as what PR #42756 is fixing.

[Enough1122]

AI code review — automated review for reference; please use your judgment.

Scope: the spawner's completion deferred now resolves on whichever of exit/close fires first (previously only close), so a detached grandchild holding stdio open no longer hangs the tool forever. Closes 7 long-standing issues.

• Correct minimal fix: first-event-wins via the existing end flag, and the close handler still prefers previously recorded exit args (exit ?? args) so the reported code/signal stays consistent.
• One behavioral edge worth a maintainer look: for normal commands, exit fires before close (stdio flush). Resolving the exit-code deferred on exit is fine as long as every consumer keeps draining stdout/stderr independently after the deferred resolves — if any caller treats deferred completion as "output fully collected", output could be truncated on the happy path. The added test covers the hang case; a regression test asserting full stdout capture on a normal large-output command would close that loop.
• Test correctly gated to non-Windows (detached-grandchild semantics differ) and cleans up the orphan with SIGKILL.
• Manual repro in the description matches the mechanism; the seven linked issues all fit this root cause.

[goedzo]

I need this fix, so how can I patch my current install with this?

[yyueniao]

I need this fix, so how can I patch my current install with this?

@goedzo help me to thumb up this PR so it can be merged sooner

[yyueniao]

@thdxr @rekram1-node Could we have this thin PR be merged, or get any feedback on this? It can close a lot of similar pending issues with only 7+3- lines of prod code changes

[goedzo]

I need this fix, so how can I patch my current install with this?

@goedzo help me to thumb up this PR so it can be merged sooner

I've actually tested this patch manually, and now at least opencode does no longer hangs on a shell. I tested it like this:

call node -e "const fs=require('fs'),path=require('path');function walk(d){let r=[];if(fs.existsSync(d)===false)return r;fs.readdirSync(d).forEach(f=>{let p=path.join(d,f);if(fs.statSync(p).isDirectory()){if((f==='.git')===false)r=r.concat(walk(p));}else if(/.(js|mjs|cjs)$/.test(f))r.push(p);});return r;}walk('node_modules/opencode-ai').forEach(f=>{let c=fs.readFileSync(f,'utf8');if(c.indexOf('proc.on("close"')>=0 || c.indexOf('proc.on(\x27close\x27')>=0){fs.writeFileSync(f,c.replace(/proc.on(\s*[\x22\x27]close[\x22\x27]/g,'proc.on(\x22exit\x22'),'utf8');console.log('[SUCCESS] Patched OpenCode Bash Exit in:',path.basename(f));}});"

[yyueniao]

@goedzo May you test this too:

node -e 'const {spawn}=require("node:child_process");const c=spawn("sleep",["3600"],{stdio:"inherit",detached:true});c.unref();console.log("done")'

because at my side, the latest opencode version still hang after showing result "done"