Skip to content

fix(tui): prevent sidebar selection copy bleed - #41713

Closed
nayafyt wants to merge 1 commit into
anomalyco:devfrom
nayafyt:selection-copy-fix
Closed

nayafyt wants to merge 1 commit into
anomalyco:devfrom
nayafyt:selection-copy-fix

Conversation

@nayafyt

@nayafyt nayafyt commented Aug 11, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #41692

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

This fixes a TUI text-selection bug where selecting conversation text could also include the right Context sidebar text in clipboard output.

Changes in this PR:

  • Mark the sidebar subtree as non-selectable in the session sidebar implementation.
  • Add a regression test to verify the subtree is recursively non-selectable.

Why this works:

  • OpenTUI selection can traverse selectable siblings during drag.
  • Making the sidebar subtree non-selectable removes sidebar text from selection candidates, so copied selection stays scoped to intended content.

How did you verify your code works?

  • Ran: ./script/bun-docker.sh run --cwd packages/tui test test/util/sidebar-selection.test.ts
  • Ran: ./script/bun-docker.sh run --cwd packages/tui typecheck
  • Manual behavior check in TUI: selecting conversation text no longer copies Context sidebar text.

Screenshots / recordings

Screenshot 2026-08-11 123209

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. labels Aug 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TUI text selection includes adjacent context pane

1 participant