fix(core): retry lazy initializer after it throws

[LHMQ878]

Issue for this PR

Closes #39596

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

lazy() set loaded = true before calling fn(). If the initializer throws, loaded is already true but value was never assigned, so every later call takes the if (loaded) fast path and returns undefined forever. The real error is swallowed and a transient failure becomes permanent.

Moving the assignment after fn() returns fixes it: a throw now leaves loaded false, so the next call retries. Success path is unchanged - still one fn() call, still caches an undefined result.

How did you verify your code works?

Added packages/core/test/util/lazy.test.ts (4 tests: caching, retry after throw, repeated failure, cached undefined).

Checked the tests actually catch the bug - reverted the src change and the two retry tests fail (Received function did not throw, received undefined); with the fix 4/4 pass.

bun typecheck clean in packages/core; bun test test/util/ 31/31 pass.

Screenshots / recordings

Not a UI change.

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

The second result (PR #12520) is unrelated—it's about an MCP search tool, not the lazy() utility function.

No duplicate PRs found

[github-actions]

Thanks for updating your PR! It now meets our contributing guidelines. 👍

[github-actions]

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

• The PR was created more than 1 month ago
• The PR had fewer than 2 positive reactions
• Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.