fix(provider): correct MiniMax M3 thinking variants - #38330
Merged
Merged
Conversation
Bkm016
pushed a commit
to Bkm016/opencode
that referenced
this pull request
Jul 28, 2026
banlanzs
pushed a commit
to banlanzs/opencode
that referenced
this pull request
Aug 6, 2026
mkvinicius
pushed a commit
to mkvinicius/Hubcli
that referenced
this pull request
Aug 12, 2026
mkvinicius
pushed a commit
to mkvinicius/Hubcli
that referenced
this pull request
Aug 12, 2026
Cherry-picks upstream 50eee1f (fix(provider): correct MiniMax M3 thinking variants, anomalyco#38330) — directly relevant to the NVIDIA/MiniMax M3 instability investigated earlier this session. NVIDIA's endpoint expects chat_template_kwargs.thinking_mode for MiniMax M3, not the generic Anthropic-style thinking.type shape. Found by scouting upstream for improvements worth pulling in; clean cherry-pick, no conflicts, 292/292 provider transform tests pass including the 2 new MiniMax M3 cases. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chat_template_kwargs.thinking_modefor MiniMax M3 variants on NVIDIA and LilacNo request translation or provider-option cleanup is added; these are ordinary model variant bodies returned by the existing variant generator.
Fixes #35027
Testing
bun test test/provider/transform.test.ts(358 pass)bun typecheckbunx prettier --check src/provider/transform.ts test/provider/transform.test.tsgit diff --check