Skip to content

feat(mcp): add resource subscription API with autoprompt - #35197

Closed
sjawhar wants to merge 2 commits into
anomalyco:devfrom
sjawhar:feat/mcp-resource-subscriptions
Closed

feat(mcp): add resource subscription API with autoprompt#35197
sjawhar wants to merge 2 commits into
anomalyco:devfrom
sjawhar:feat/mcp-resource-subscriptions

Conversation

@sjawhar

@sjawhar sjawhar commented Jul 3, 2026

Copy link
Copy Markdown

Issue for this PR

Refs #28567 (partial — this PR delivers the resource-subscription slice of "full MCP client capabilities")

Re-submission of #20672 (closed by automated cleanup) and #14569 (earlier version), rebased onto current dev. The previous PR could not be reopened because the branch has been force-pushed since closure.

Type of change

  • Bug fix
  • New feature

What does this PR do?

Adds MCP resource subscription support on top of the upstream MCP client:

  • New subscriptions and autoprompt fields in MCP server config
  • TUI toasts on mcp.resource.updated and mcp.resource.list.changed events
  • Optional auto-prompt: when a subscribed resource updates and the session is idle, automatically prompt the AI to react to the change

How did you verify your code works?

test/mcp/lifecycle.test.ts covers the subscription lifecycle. bun typecheck passes. Manual smoke test against a sample MCP server.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Refs #28567

Supersedes #29355 (closed by the inactivity bot). Rebased onto latest dev with all merge conflicts resolved; typecheck and targeted tests pass on the fork branch.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate PRs Found

Based on the search results, there are related PRs addressing similar MCP resource functionality:

  1. feat(mcp): support resource subscriptions #32936 - feat(mcp): support resource subscriptions

    • Directly related to resource subscription support

  2. feat(mcp): publish resource list change events #32478 - feat(mcp): publish resource list change events

    • Addresses the mcp.resource.list.changed event aspect of this PR

  3. feat(mcp): support resource update notifications #31398 - feat(mcp): support resource update notifications

    • Related to handling mcp.resource.updated events

These PRs overlap with the functionality described in PR #35197. Review the status and content of these existing PRs to determine if they should be consolidated or if #35197 represents a comprehensive rewrite/update that supersedes them.

@sjawhar
sjawhar force-pushed the feat/mcp-resource-subscriptions branch 2 times, most recently from 16676a1 to 002cef1 Compare July 13, 2026 17:01
@legion-implementer
legion-implementer Bot force-pushed the feat/mcp-resource-subscriptions branch 2 times, most recently from 6a39a50 to 84d4cc9 Compare July 22, 2026 16:51
@sjawhar
sjawhar force-pushed the feat/mcp-resource-subscriptions branch from 84d4cc9 to ce22f7d Compare July 22, 2026 17:34
opencode and others added 2 commits July 27, 2026 07:32
opencode
release: v1.18.7
0298184
@sjawhar
feat(mcp): add resource subscription API on top of upstream's resourc…
6c20859 
…e read

Adds MCP client subscribeResource/unsubscribeResource support on top of
upstream's existing readResource API:

- New BusEvents: mcp.resource.updated, mcp.resource.list.changed
- New MCP.Service methods: subscribe(client, uri), unsubscribe(client, uri),
  subscriptions()
- New State.subscriptions tracking (Map<server, Set<uri>>)
- New supportsSubscriptions helper (gates on getServerCapabilities)
- New notification handlers: ResourceUpdatedNotificationSchema and
  ResourceListChangedNotificationSchema
- readResource now auto-subscribes after a successful read
- New config.mcp[name].subscriptions and config.mcp[name].autoprompt fields
- TUI app.tsx surfaces resource.updated/resource.list.changed events as
  toasts, optionally triggering an AI prompt when autoprompt is enabled
- Lifecycle test covering subscribe/unsubscribe round-trip
- Stub fields added to all MCP.Service mock layers

Used by Oh My Open Agents skill-loaded MCPs (WhatsApp, Envoy plugin, etc.)
to react to push notifications from MCP servers.
@sjawhar
sjawhar force-pushed the feat/mcp-resource-subscriptions branch from ce22f7d to 6c20859 Compare July 27, 2026 14:59
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

@github-actions github-actions Bot closed this Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hona Hona Awaiting requested review from Hona Hona is a code owner
@Brendonovich Brendonovich Awaiting requested review from Brendonovich Brendonovich is a code owner

Assignees

No one assigned

Labels

automated-pr-cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sjawhar