fix: preserve Bedrock DeepSeek model ids by YeEmrick · Pull Request #34441 · anomalyco/opencode

YeEmrick · 2026-06-29T14:20:32Z

Issue for this PR

Type of change

Bug fix
New feature
Refactor / code improvement
Documentation

What does this PR do?

Bedrock DeepSeek model IDs were being treated like generic cross-region model IDs. That changed deepseek.v3.2 into us.deepseek.v3.2, which Bedrock rejects for the on-demand model.

This PR keeps explicit Bedrock model identifiers intact:

deepseek.v3.2 stays deepseek.v3.2
arn:aws:bedrock:...:foundation-model/... stays unchanged
already-prefixed profile IDs like us.deepseek.r1-v1:0 still pass through unchanged

How did you verify your code works?

Tested:

cd packages/opencode && bun test test/provider/amazon-bedrock.test.ts
cd packages/core && bun typecheck
git diff --check

Reviewer can confirm by configuring amazon-bedrock/deepseek.v3.2 and checking that the provider receives deepseek.v3.2, not us.deepseek.v3.2.

Local note: cd packages/core && bun test test/plugin/provider-amazon-bedrock.test.ts currently fails before this PR assertions with Cannot access 'AmazonBedrockPlugin' before initialization.

Screenshots / recordings

N/A, provider behavior only.

Checklist

I have tested my changes locally
I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

github-actions · 2026-06-29T14:20:43Z

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

Open an issue describing the bug/feature (if one doesn't exist)
Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

github-actions · 2026-06-29T14:22:01Z

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate Found

PR #18948: fix(provider): prevent Bedrock from prefixing ARN and deepseek.v3.2 model IDs
#18948

This appears to be directly related to the current PR #34441. Both PRs address the same issue of preserving Bedrock DeepSeek model IDs (preventing prefixing/normalization that shouldn't happen).

You should check if PR #18948 was previously closed or if this is addressing a regression or incomplete fix.

github-actions · 2026-06-29T15:01:58Z

Thanks for updating your PR! It now meets our contributing guidelines. 👍

YeEmrick · 2026-06-29T15:21:44Z

Updated after rechecking the Bedrock DeepSeek R1 profile behavior.

This PR now preserves the intended split:

deepseek.v3.2 passes through unchanged.
Bedrock foundation-model ARNs pass through unchanged.
Already-prefixed profiles like us.deepseek.r1-v1:0 pass through unchanged.
Unprefixed deepseek.r1-v1:0 in us-* regions still resolves to us.deepseek.r1-v1:0.

This is related to #18948, but this PR also covers the current packages/core/src/plugin/provider/amazon-bedrock.ts plugin path in addition to the legacy packages/opencode/src/provider/provider.ts path.

Verified locally:

cd packages/opencode && bun test test/provider/amazon-bedrock.test.ts
cd packages/core && bun typecheck
git diff --check

Known unrelated local blockers while testing broader gates:

cd packages/core && bun test test/plugin/provider-amazon-bedrock.test.ts still fails before assertions with Cannot access 'AmazonBedrockPlugin' before initialization.
cd packages/opencode && bun typecheck fails in unchanged src/bus/global.ts EventEmitter typing.

Robin1987China

LGTM. The narrowing from "deepseek" to "deepseek.r1" correctly distinguishes cross-region inference profiles (R1) from on-demand models (V3.2). The arn: guard is a solid defensive addition — foundation-model ARNs should never be region-prefixed.

One non-blocking note: if Bedrock adds DeepSeek R2 models that also require cross-region profiles, the requiresPrefix list will need updating. The narrow match is the safer choice for now.

github-actions · 2026-07-29T22:20:57Z

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

The PR was created more than 1 month ago
The PR had fewer than 2 positive reactions
Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

marc-jan · 2026-08-01T13:05:24Z

Can this be re-opened and merged? It was already reviewed, but now closed. It is still a problem if you are stuck with AWS and need to use bedrock.

Upstream v1.18.29 (1674747, merged at 18a4845) -> v1.18.30 (3104c14), 28 commits / 105 files. Staged delta vs pre-merge fork HEAD is identical to the upstream tag-to-tag diff (105 files, +1676/-403), confirming a clean adoption. Functional changes: - feat(opencode): port Astra system prompt from v2 (anomalyco#48057) — new session/prompt/gpt-astra.txt wired through system.ts; fork's system transforms live in the openchamber plugin, no overlap. - fix: preserve Bedrock DeepSeek model ids (anomalyco#34441) — provider.ts Bedrock loader passes arn: model ids through unmodified and tightens the cross-region prefix match from "deepseek" to "deepseek.r1"; inside the custom Azure/Bedrock loader region, disjoint from the fork snapshot architecture. - fix(provider): preserve explicit OpenAI service tiers (anomalyco#47671). - fix(opencode): add GitLab reasoning variants (anomalyco#47306) — transform.ts reasoningEffort now routes gitlab gpt-family to reasoningEffort and claude-family to adaptive thinking; disjoint from the fork GLM/ZhiPu normalization block, which remains intact (+77 fork-only lines). - SDK bumps: @ai-sdk/openai 3.0.88, @ai-sdk/azure 3.0.93, gitlab-ai-provider 6.15.0 (8 packages installed via bun install). - console: oauth client metadata document (anomalyco#47737), Chatwoot enterprise form (anomalyco#47488), openai usage normalization + tier threshold (anomalyco#47342), localized refund FAQs, zen model table updates (muse spark); go.mdx client session compatibility docs incl. zh translation. Conflicts resolved: 29 package.json version bumps (rebranded 1.18.30-sscity with a version-generic pattern after the v1.18.27 incident), bun.lock (took upstream, rebranded workspace entries via bun install). Fork deltas verified intact vs v1.18.30: ProviderSnapshot architecture (+492 in provider.ts), deferred snapshot init, GLM normalization (+77 in transform.ts), config getFresh/commitFresh (+14). Tests: provider, transform, bedrock, config, v2, azure plugin, session retry/llm — 1058 pass / 0 fail across 15 files (22 new upstream tests included); typecheck clean. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

…ck ARN/DeepSeek ids Two small upstream fixes to the opencode/provider/provider.ts "custom" loaders and shared wrapSSE helper, both completing partial ports that this fork's core-package copies already received but this file's duplicated logic missed: 1. wrapSSE(): the timeout path called `void reader.cancel(err)`, leaving an unhandled promise rejection when the underlying stream had already errored. core/aisdk.ts's copy of this function was already fixed (commit ac3b15b); this completes the port for the near-duplicate copy here. Ported from upstream ac1758c -> no, from upstream 69c172e ("fix(provider): handle SSE reader cancel rejections (anomalyco#44944)"). 2. amazon-bedrock custom loader's getModel(): double-prefixed full Bedrock ARNs (`arn:...`, which Bedrock rejects with a prefix) and over-matched "deepseek" (prefixing non-R1 DeepSeek models that don't support cross-region inference). The core Bedrock plugin (packages/core/src/plugin/provider/amazon-bedrock.ts) already got this fix (commit d66cefe); this completes the port for the legacy "custom" loader's own copy of the same logic. Ported from upstream ac1758c ("fix: preserve Bedrock DeepSeek model ids (anomalyco#34441)"). Verified via manual `tsgo --noEmit` on packages/core and packages/opencode (clean) and oxlint on the changed file (0 errors, pre-existing warnings only, none on changed lines). Full monorepo `bun turbo typecheck` cannot run in this sandbox because three unrelated packages (console-support, console-app, stats-app) depend on `@solidjs/start` pinned to a pkg.pr.new preview build blocked by this environment's network policy — a known, previously-documented sandbox limitation (see fork-expert skill's upstream-sync.md), not a regression from this change. The equivalent "typecheck" GitHub Actions check passed clean on PR #234, which hit the same sandbox limitation for its own real-code changes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SHQKcGH7ayRe8UHJ9CAPQJ

Port upstream opencode ac1758c0e6 (anomalyco/opencode#34441), provider.ts hunks only: pass arn: model references through untouched, and narrow the us-region cross-region prefix list from bare "deepseek" to "deepseek.r1" so non-r1 DeepSeek ids (e.g. deepseek.v3.2) are no longer over-prefixed into us.deepseek.v3.2. Upstream's second landing site (core/src/plugin/provider/amazon-bedrock.ts resolveModelID) does not exist in this fork; the fork's mantle path (selectBedrockMantleLanguageModel) does no region prefixing, so no mantle-side change applies. Adds the upstream test matrix (bare v3.2, r1 prefixing, pre-prefixed profile id, arn passthrough) adapted to the fork's WithInstance/AppRuntime test shape. Upstream-Sha: ac1758c0e6

Co-authored-by: yeqisong <yeqisong@authing.com>

fix: preserve Bedrock DeepSeek model ids

1cdde1f

github-actions Bot added needs:issue needs:compliance This means the issue will auto-close after 2 hours. labels Jun 29, 2026

Merge branch 'dev' into bedrock-deepseek-id

f4f5317

github-actions Bot removed needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels Jun 29, 2026

fix(provider): preserve Bedrock DeepSeek R1 profile

394aa3a

Merge branch 'dev' into bedrock-deepseek-id

3718bc0

Robin1987China reviewed Jun 30, 2026

View reviewed changes

Merge branch 'dev' into bedrock-deepseek-id

f78a67f

github-actions Bot closed this Jul 29, 2026

github-actions Bot added the automated-pr-cleanup label Jul 29, 2026

github-actions Bot mentioned this pull request Jul 29, 2026

📊 AI CLI 工具社区动态日报 2026-07-30 junlinzhao327-oss/big_model_radar#199

Open

rrinaldi mentioned this pull request Aug 20, 2026

Amazon Bedrock provider: DeepSeek V3/V3.1/V3.2 broken by incorrect "us." cross-region prefix in resolveModelID #43679

Closed

rekram1-node reopened this Sep 6, 2026

rekram1-node merged commit ac1758c into anomalyco:dev Sep 8, 2026
8 checks passed

unemployabot Bot mentioned this pull request Sep 9, 2026

Termux v1.18.30 wallentx/opencode-termux#74

Merged

A-x6 mentioned this pull request Sep 13, 2026

feat(bolt): upstream picks, memory guard, and typecheck fixes bolt-builder/bolt-cli#408

Merged

github-actions Bot mentioned this pull request Sep 14, 2026

Informe upstream (semanal) jaminsmoke/Jarvis#52

Open

alltomatos mentioned this pull request Sep 15, 2026

fix(provider): complete Bedrock ARN/DeepSeek and SSE reader-cancel upstream ports alltomatos/opencode#241

Open

3 tasks

rossigee pushed a commit to rossigee/opencode that referenced this pull request Sep 18, 2026

fix: preserve Bedrock DeepSeek model ids (anomalyco#34441)

139d2e9

Co-authored-by: yeqisong <yeqisong@authing.com>

Navigation Menu

fix: preserve Bedrock DeepSeek model ids - #34441

fix: preserve Bedrock DeepSeek model ids#34441
rekram1-node merged 5 commits into
anomalyco:devfrom
YeEmrick:bedrock-deepseek-id

YeEmrick commented Jun 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

YeEmrick commented Jun 29, 2026

Uh oh!

Robin1987China left a comment

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

marc-jan commented Aug 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

YeEmrick commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue for this PR

Type of change

What does this PR do?

How did you verify your code works?

Screenshots / recordings

Checklist

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Potential Duplicate Found

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

YeEmrick commented Jun 29, 2026

Uh oh!

Robin1987China left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

marc-jan commented Aug 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

YeEmrick commented Jun 29, 2026 •

edited

Loading