fix(opencode): prevent Warp Windows tab close on TUI exit - #24789
Closed
NicoAvanzDev wants to merge 1 commit into
Closed
NicoAvanzDev wants to merge 1 commit into
NicoAvanzDev wants to merge 1 commit into
Conversation
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
NicoAvanzDev
marked this pull request as ready for review
April 28, 2026 12:50
Author
|
Closing in favor of the alternate Windows console teardown fix, which has been tested locally. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #24790
Type of change
What does this PR do?
Warp on Windows closes the tab when the TUI exits from OpenTUI alternate-screen mode. This changes the TUI renderer to use main-screen mode only for Warp on Windows, while keeping the existing renderer behavior for other terminals. It also consumes the app-exit key before tearing down the prompt so Ctrl+D does not leak to the shell after exit.
How did you verify your code works?
bun typecheckfrompackages/opencode.bun run script/build.ts --single --skip-install --skip-embed-web-uifrompackages/opencode./exitand Ctrl+D.Screenshots / recordings
Not included. This is terminal exit behavior; manual verification confirmed the Warp tab now stays open and returns to the shell.
Checklist