Skip to content

fix(opencode): prevent Warp Windows tab close on TUI exit - #24789

Closed
NicoAvanzDev wants to merge 1 commit into
anomalyco:devfrom
NicoAvanzDev:warp-windows-exit
Closed

NicoAvanzDev wants to merge 1 commit into
anomalyco:devfrom
NicoAvanzDev:warp-windows-exit

Conversation

@NicoAvanzDev

@NicoAvanzDev NicoAvanzDev commented Apr 28, 2026 •

Copy link
Copy Markdown

Issue for this PR

Closes #24790

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Warp on Windows closes the tab when the TUI exits from OpenTUI alternate-screen mode. This changes the TUI renderer to use main-screen mode only for Warp on Windows, while keeping the existing renderer behavior for other terminals. It also consumes the app-exit key before tearing down the prompt so Ctrl+D does not leak to the shell after exit.

How did you verify your code works?

  • Ran bun typecheck from packages/opencode.
  • Ran bun run script/build.ts --single --skip-install --skip-embed-web-ui from packages/opencode.
  • Manually tested the built Windows binary in Warp with /exit and Ctrl+D.

Screenshots / recordings

Not included. This is terminal exit behavior; manual verification confirmed the Warp tab now stays open and returns to the shell.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added needs:title needs:compliance This means the issue will auto-close after 2 hours. labels Apr 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hey! Your PR title Fix Warp Windows TUI exit doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@NicoAvanzDev NicoAvanzDev changed the title Fix Warp Windows TUI exit fix(opencode): prevent Warp Windows tab close on TUI exit Apr 28, 2026
@github-actions github-actions Bot removed needs:title needs:compliance This means the issue will auto-close after 2 hours. labels Apr 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@NicoAvanzDev
NicoAvanzDev marked this pull request as ready for review April 28, 2026 12:50
@NicoAvanzDev

Copy link
Copy Markdown
Author

Closing in favor of the alternate Windows console teardown fix, which has been tested locally.

@NicoAvanzDev
NicoAvanzDev deleted the warp-windows-exit branch April 28, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warp on Windows closes tab when TUI exits

1 participant