refactor(tool): convert write tool to Tool.defineEffect - #21901
Merged
Merged
Conversation
kitlangton
force-pushed
the
kit/tool-effect-write
branch
3 times, most recently
from
April 10, 2026 19:45
48ff033 to
e49466c
Compare
kitlangton
marked this pull request as ready for review
April 10, 2026 19:46
kitlangton
force-pushed
the
kit/tool-effect-write
branch
from
April 10, 2026 19:48
e49466c to
038f397
Compare
Migrate WriteTool to use Tool.defineEffect with proper Effect services. LSP static calls replaced with yielded LSP.Service instance methods.
kitlangton
force-pushed
the
kit/tool-effect-write
branch
from
April 10, 2026 19:50
038f397 to
69ac261
Compare
mrsimpson
pushed a commit
to mrsimpson/opencode
that referenced
this pull request
Apr 14, 2026
AIALRA-0
pushed a commit
to AIALRA-0/opencode-turn-engine
that referenced
this pull request
Jun 10, 2026
MarsQiu007
referenced
this pull request
in MarsQiu007/openNovel
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WriteToolfromTool.definetoTool.defineEffectwith proper Effect servicesLSP.Servicein the outer Effect.gen and replace staticLSP.touchFile/LSP.diagnosticscalls with instance methods (lsp.touchFile/lsp.diagnostics)Filesystem.*,FileTime.*,Format.file,ctx.ask,Bus.publish) withEffect.promiseToolRegistryto resolve WriteTool as an Effect (const writetool = yield* WriteTool) and pass it toTool.init(writetool)ManagedRuntimefor resolving the Effect-based WriteToolTest plan
bun run typecheckpasses (no write-related errors)bun run test test/tool/write.test.ts— all 13 tests pass