This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Repository navigation
refactor(webpack-prerender): decouple config from plugin - #464
Closed
filipesilva wants to merge 1 commit into
Closed
filipesilva wants to merge 1 commit into
filipesilva wants to merge 1 commit into
Conversation
|
|
||
| This webpack plugin is meant to be used together with a prerender entry file | ||
| exporting two functions: | ||
| - `getBoostrap`, which returns a Bootloader |
Contributor
Author
There was a problem hiding this comment.
Nice catch, thanks!
Contributor
|
I have a new design for this now that allows for prerendering all of the routes to generate a static site using angular 2. closing for now |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR decouples the prerender config from the webpack plugin.
Currently both behaviours are coupled, which can cause problems when including the plugin in tool-like projects that manipulate other projects. The two projects can have different
@angular/xandangular2-universaldependencies, which would cause type errors on providers due to different type references.Additionally, node require cache for app files is also deleted so that serialize can render an up to date version of the app.
The config file exports the functions that the plugin needs to alter the prerendered template, but the dependencies are decoupled.
Yes, instructions are included in the README.md file.