This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 22, 2024. It is now read-only.
Versions after v0.100.5 break mobile-toolkit apps built from angular-cli - dist/index.html output is undefined #445
Description
- I'm submitting a ...
- [X ] bug report
- What modules are related to this pull-request
- express-engine
- grunt-prerender
- gulp-prerender
- hapi-engine
- preboot
- universal-preview
- universal
- webpack-prerender
- What is the current behavior?
Unfortunately there is no error output at all from ng build on the angular-cli beta.6. This works fine when mobile-toolkit and universal are not part of the app. It also worked fine in angular-cli beta.5.
Contents of dist/index.html:
undefinedAfter investigating, it's the angular-universal library change that caused the breakage. Reverting back from 0.101.5 to 0.100.5 fixes the failure. 0.101.9 and 0.102.1 also fail to output anything but undefined to dist/index.html.
- What is the expected behavior?
Contents of dist/index.html should be full of HTML.
- Please tell us about your environment:
- Angular version: 2.0.0-RC.1
- Browser: all
- Language: TypeScript 1.8.10
- OS: Mac OS X El Capitan
- Platform: NodeJs
- Other information
ng build generates dist/index.html w/ contents of 'undefined' after angular-cli beta.6 upgrade mobile-toolkit#66
Metadata
Metadata
Assignees
Labels
No labels
Activity
MarkPieszak commentedon Jun 19, 2016
Hey Michael, I'll take a look and see what I can find. Are you using router-deprecated? It's all that's supported at the moment at least.
Splaktar commentedon Jun 19, 2016
@MarkPieszak yes.
Splaktar commentedon Jun 22, 2016
This is also being tracked here: angular/angular-cli#958
PatrickJS commentedon Jun 24, 2016
@Splaktar universal has been updated to rc.3 via
0.103.2can you check it out to see if it fixes the problem. Also setasync: truein the universal configSplaktar commentedon Jun 24, 2016
@gdi2290 I will give it a shot after my talk tonight. Thank you!
Splaktar commentedon Jun 26, 2016
This will take a bit more time to get to.
For my actual app, I'm blocked by:
platosha/angular-polymer#26
For a new app via
ng new testApp --mobile, I'm blocked by:angular/angular-cli#1174
I might be able to disable angular2-polymer temporarily in order to test this in my app. Will try that when I get some more time.
MarkPieszak commentedon Jun 26, 2016
I know typically you'd want to use DomAdapter instead of using window directly, but not sure how that could be added to angular2-polymer, Patrick might have a good idea there.
Is the CLI using Universal 103.2? That one includes the new alpha router and those peerDep fixes.
Splaktar commentedon Jun 26, 2016
@MarkPieszak angular-cli
beta.8is still using angular-universal0.100.5.I manually upgraded a new CLI project to
0.103.2but then that threw errors because something apparently still depended on@angular/router-deprecated. So I added that, then it threw exceptions due toThe selector "app-root" did not match any elements. More details on that exception here: angular/angular-cli#1174 (comment)Splaktar commentedon Jun 26, 2016
@gdi2290 Thank you for making a PR for the
async: truesetting: angular/angular-cli#1163Splaktar commentedon Jun 27, 2016
I was able to verify this is working again with
0.103.3: angular/angular-cli#1174 (comment)angular-automatic-lock-bot commentedon Sep 4, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.