Skip to content
This repository was archived by the owner on Oct 12, 2021. It is now read-only.

Added Support for applicationServerKey in Push Subscribe - #122

Closed
treyrich wants to merge 2 commits into
angular:masterfrom
tractus:master
Closed

treyrich wants to merge 2 commits into
angular:masterfrom
tractus:master

Conversation

@treyrich

Copy link
Copy Markdown

Fixes #121.

I'm not entirely sure that this is the best way to approach this. I'm not positive why the userVisibleOnly key was not configurable, but it's possible that this solution needs to be revised to not allow the user calling registerForPush to set it themselves.

Either way, review and let me know.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@treyrich

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@treyrich

Copy link
Copy Markdown
Author

Resolved in 950f99f

@treyrich treyrich closed this May 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants