Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

fix(@angular-devkit/build-optimizer): only prefix top-level functions… - #62

Merged
filipesilva merged 1 commit into
angular:masterfrom
filipesilva:prefix-toplevel-angular
Aug 2, 2017
Merged

filipesilva merged 1 commit into
angular:masterfrom
filipesilva:prefix-toplevel-angular

Conversation

@filipesilva

Copy link
Copy Markdown
Contributor

… in Angular packages

Fix #51
Fix #52

getFoldFileTransformer,
]);
} else if (hasDecorators.test(content) || hasCtorParameters.test(content)) {
getTransforms.push(...[

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just

    getTransforms.push(getScrubFileTransformer, getFoldFileTransformer);

Push accepts a variable number of arguments.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boooriiing 😫

...[a, b] is so much cooler 😛

@hansl hansl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 nit. LGTM

@filipesilva
filipesilva merged commit 4ef16c2 into angular:master Aug 2, 2017
@filipesilva
filipesilva deleted the prefix-toplevel-angular branch August 2, 2017 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants