Repository navigation
fix(github-actions): do Github requests serially in branch manager - #992
Merged
Merged
Conversation
Branch manager occasionally fails due to secondary rate limit. Sometimes, almost 200 concurrent requests were performed. https://github.com/angular/angular/actions/runs/3766259367/jobs/6402572451 Github recommends to make requests for a single user or client ID serially. See: https://docs.github.com/en/rest/guides/best-practices-for-integrators?apiVersion=2022-11-28#dealing-with-secondary-rate-limits Closes angular#961
alan-agius4
force-pushed
the
branch-manager-rate-limit
branch
from
January 23, 2023 12:10
855610b to
b53c8c6
Compare
alan-agius4
added
action: review
alan-agius4
requested review from
devversion and
josephperrott
and removed request for
josephperrott
January 23, 2023 12:11
Contributor
Author
|
One other probably better alternative would be to use https://github.com/octokit/plugin-throttling.js throughout. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch manager occasionally fails due to secondary rate limit. Sometimes, almost 200 concurrent requests were performed.
Github recommends to make requests for a single user or client ID serially. See: https://docs.github.com/en/rest/guides/best-practices-for-integrators?apiVersion=2022-11-28#dealing-with-secondary-rate-limits
Closes #961
NB: Currently, this workflow is disabled in angular/angular, not sure if the limits was the reason behind this.