Repository navigation
ci(angular/dev-infra): add CI checks to ensure lock-closed action is built correctly #769
Description
The problem
Currently, the angular/dev-infra repository relies on a pre-commit git hook for building the lock-closed action, in order to ensure that the changes made in the source code (e.g. src/main.ts) will also be included in the built script that is actually used when running the action (i.e. lib/bundle.js).
However, it is easy to miss this step (for example if someone submit a PR via the GitHub UI or commits review suggestions via the GitHub UI or has git hooks disabled, etc.).
This can result in issues such as angular/angular#39358, where the fix is in the source code but not in the built script (that is actually used).
The solution
Introduce CI checks to angular/dev-infra that would ensure that the built script (lib/bundle.js) is indeed up-to-date with the source code (src/main.ts).
Activity
AndrewKushnir commentedon Oct 28, 2020
@gkalpak, I've set
P3as a priority, please change it if needed. Thank you.gkalpak commentedon Aug 17, 2022
This has been addressed. The
lock-closedGitHub action (and all other GitHub actions) has an esbuild_checked_in check.angular-automatic-lock-bot commentedon Sep 17, 2022
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.