Skip to content

Consider adding a wrapper around jasmine_node_test rule #338

Description

@AndrewKushnir

PR angular/angular#44505 updated angular/angular repo to use ES2015 instead of ES5. The mentioned change revealed that there is a duplication in a lot of places where the bootstrap is defined, for example:

jasmine_node_test(
    bootstrap = ["//tools/testing:node_no_angular_es2015"],

or:

jasmine_node_test(
    bootstrap = ["//tools/testing:node_es2015"],

This makes further ES version upgrades quite error-prone (and time-consuming), since we need to change ~100 files.

The proposal is to create a couple wrappers, for example:

  • ng_node_test
  • no_ng_node_test

and specify bootstrap there by default (and allow overrides), so that it's easier to update ES version.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions