Skip to content

Replace benchmark concatjs devserver instance with custom devserver #318

Open

Description

@devversion

The ConcatJS devserver in rules_nodejs seems to not work with with M1 Apple, neither does it work with Windows anymore. The Windows breakage seems to have started with recent runfile resolution changes there.

We should be using the Windows-compatible and less magical devserver that we maintain in Angular Components.

Target //bazel/benchmark/component_benchmark/test:test_server up-to-date:
  dist/bin/bazel/benchmark/component_benchmark/test/test_server_launcher.sh
  dist/bin/bazel/benchmark/component_benchmark/test/test_server
  dist/bin/bazel/benchmark/component_benchmark/test/test_server.exe
INFO: Elapsed time: 1.077s, Critical Path: 0.02s
INFO: 4 processes: 4 internal.
INFO: Build completed successfully, 4 total actions
INFO: Build completed successfully, 4 total actions
Could not find runfile dev-infra/../npm/node_modules/zone.js/bundles/zone.umd.js, got error Runfile ../npm/node_modules/zone.js/bundles/zone.umd.js: could not locate fileFailed to read script dev-infra/../npm/node_modules/zone.js/bundles/zone.umd.js: open : The system cannot find the file specified.
Could not find runfile dev-infra/../npm/@bazel/concatjs/third_party/npm/requirejs/require.js, got error Runfile ../npm/@bazel/concatjs/third_party/npm/requirejs/require.js: could not locate fileFailed to read script dev-infra/../npm/@bazel/concatjs/third_party/npm/requirejs/require.js: open : The system cannot find the file specified.
Server listening on http://paul-windows:4200/

Activity

  1. self-assigned this
    on Dec 1, 2021
  2. devversion commented on Feb 26, 2022

    @devversion
    MemberAuthor

    This is done in COMP and this repo. There are some leftovers in FW that need to switch for M1 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions