Skip to content

fix(aria/accordion): ensure right attribute is set when used as a host directive - #33839

Merged
crisbeto merged 1 commit into
angular:mainfrom
crisbeto:33810/aria-accordion-attr
Sep 18, 2026
Merged

crisbeto merged 1 commit into
angular:mainfrom
crisbeto:33810/aria-accordion-attr

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Some functionality in the AccordionGroupPattern relies on the ngAccordionTrigger attribute being present. These changes add it as an explicit host binding in case the directive is used as a host directive.

…t directive

Some functionality in the `AccordionGroupPattern` relies on the `ngAccordionTrigger` attribute being present. These changes add it as an explicit host binding in case the directive is used as a host directive.
@crisbeto
crisbeto requested a review from ok7sai September 18, 2026 14:11
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Sep 18, 2026
@pullapprove
pullapprove Bot requested a review from andrewseguin September 18, 2026 14:11
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 18, 2026
@crisbeto
crisbeto merged commit 6a9f2d0 into angular:main Sep 18, 2026
33 of 35 checks passed
@crisbeto

Copy link
Copy Markdown
Member Author

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Sep 18, 2026
…t directive (#33839)

Some functionality in the `AccordionGroupPattern` relies on the `ngAccordionTrigger` attribute being present. These changes add it as an explicit host binding in case the directive is used as a host directive.

(cherry picked from commit 6a9f2d0)
crisbeto added a commit that referenced this pull request Sep 18, 2026
…t directive (#33839)

Some functionality in the `AccordionGroupPattern` relies on the `ngAccordionTrigger` attribute being present. These changes add it as an explicit host binding in case the directive is used as a host directive.

(cherry picked from commit 6a9f2d0)
@angular-automatic-lock-bot

Copy link
Copy Markdown

This pull request has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: aria/accordion target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants