You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
bug alpha 6-3 - url_resolver.js:238Uncaught TypeError: uri.match is not a function, when using latest compiler-builds #963
Building a project with alpha 6-3 and the latest compiler build using ngModules seems to crash when you use materials modules. This commit to the compiler broke it: angular/angular@83e2d3d
On line 238 of url_resolver.js, if you change
function _split(uri) {
return uri.match(_splitRe);
}
to
function _split(uri) {
if (typeof uri === 'string')
return uri.match(_splitRe);
}
it will work, as it appears that the material modules are exporting numbers instead of strings. If I console.log uri, MdButtonModule will pass it the number 436 and also the string 'package:436' for example. The number is causing the crash.
I know it was mentioned that this is experimental release, but just making sure that this is a known issue and addressed before next release.
Same issue as @MatteoNY, but updating to 2.0.0-alpha.7-8. I reverted to known-good 2.0.0-alpha.7-2 and incremented the version upward until it started breaking again: 2.0.0-alpha.7-5 works, 2.0.0-alpha.7-6 throws the error, as does 2.0.0-alpha.7-8 ( I didn't actually test alpha.7-7)
The @latest tag on npm still points to alpha.7-4. Releases above that are tagged as @experimental and are not meant for general consumption (they're typically us testing integrations with in-progress work on angular core or Google internal tooling).
angular-automatic-lock-bot commented on Sep 5, 2019
Activity
jelbourn commentedon Aug 9, 2016
I don't think this is an issue with the released alpha.7. Feel free to re-file if you're still running into a problem.
MatteoNY commentedon Aug 24, 2016
I updated to MD2 ^2.0.0-alpha.7-7 and I had the same problem. Thanks qdouble for your fix it resolved the issue. RC-5 CLI with webpack.2. :-)
ggranum commentedon Aug 24, 2016
Same issue as @MatteoNY, but updating to 2.0.0-alpha.7-8. I reverted to known-good 2.0.0-alpha.7-2 and incremented the version upward until it started breaking again: 2.0.0-alpha.7-5 works, 2.0.0-alpha.7-6 throws the error, as does 2.0.0-alpha.7-8 ( I didn't actually test alpha.7-7)
jelbourn commentedon Aug 24, 2016
The
@latesttag on npm still points to alpha.7-4. Releases above that are tagged as@experimentaland are not meant for general consumption (they're typically us testing integrations with in-progress work on angular core or Google internal tooling).angular-automatic-lock-bot commentedon Sep 5, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.