Skip to content

fix(storage): Add our zone wrappers for download url and meta-data - #1548

Merged
jamesdaniels merged 1 commit into
angular:masterfrom
jamesdaniels:storage_zone_work
Apr 5, 2018
Merged

jamesdaniels merged 1 commit into
angular:masterfrom
jamesdaniels:storage_zone_work

Conversation

@jamesdaniels

Copy link
Copy Markdown
Contributor

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

Code sample

@jamesdaniels jamesdaniels self-assigned this Apr 5, 2018
@jamesdaniels
jamesdaniels requested a review from davideast April 5, 2018 19:55

@davideast davideast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @jamesdaniels! Thanks for getting this fix in on the go.

Comment thread src/storage/ref.ts
* @param ref
*/
export function createStorageRef(ref: Reference): AngularFireStorageReference {
export function createStorageRef(ref: Reference, scheduler: FirebaseZoneScheduler): AngularFireStorageReference {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad, but necessary. 😢

@jamesdaniels
jamesdaniels merged commit 99a2a81 into angular:master Apr 5, 2018
@jamesdaniels
jamesdaniels deleted the storage_zone_work branch April 5, 2018 20:56
myspivey pushed a commit to myspivey/angularfire2 that referenced this pull request Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants