Skip to content

feat(compiler): new semantics for template attributes and view variabl... - #213

Closed
tbosch wants to merge 1 commit into
angular:masterfrom
tbosch:template
Closed

tbosch wants to merge 1 commit into
angular:masterfrom
tbosch:template

Conversation

@tbosch

@tbosch tbosch commented Nov 19, 2014

Copy link
Copy Markdown
Contributor

...es.

  • Supports <div template=“…”>, including parsing the expressions within
    the attribute.
  • Supports <template let-ng-repeat=“rows”>
  • Adds attribute interpolation (was missing previously)

@tbosch

tbosch commented Nov 19, 2014

Copy link
Copy Markdown
Contributor Author

@vsavkin Could you review this? I would like to land it tomorrow, so that @rkirov can start working on the ViewPort...

@googlebot

Copy link
Copy Markdown

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add generics with to indicate the type

…ables.

- Supports `<div template=“…”>`, including parsing the expressions within
  the attribute.
- Supports `<template let-ng-repeat=“rows”>`
- Adds attribute interpolation (was missing previously)
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 5, 2019
dalejodc pushed a commit to dalejodc/angular that referenced this pull request Apr 30, 2021
Co-authored-by: Julio Lagos <julio.lagos.carrera@gmail.com>
Co-authored-by: Daniel Díaz <36966980+dalejodc@users.noreply.github.com>
Co-authored-by: Michael Prentice <splaktar@gmail.com>

Fixes angular#213
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants