Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

examples(tutorial): misc fixes to issues from failed e2e - #1936

Merged
wardbell merged 1 commit into
angular:masterfrom
IdeaBlade:chalin-dart-tut-misc-fixes-0720
Jul 20, 2016
Merged

wardbell merged 1 commit into
angular:masterfrom
IdeaBlade:chalin-dart-tut-misc-fixes-0720

Conversation

@chalin

@chalin chalin commented Jul 20, 2016

Copy link
Copy Markdown
Contributor

Misc fixes to problems with the tutorial examples, as detected by the new e2e tests. Now the toh-4 index.html is identical to those of the previous parts.

Fixes #1609.
Supersedes #1785.

Misc fixes to problems with the tutorial examples, as detected by the new e2e tests. Now the toh-4 index.html is identical to those of the previous parts.

Fixes angular#1609.
@chalin

chalin commented Jul 20, 2016

Copy link
Copy Markdown
Contributor Author

@kwalrath @wardbell @Foxandxss : ready for review.

@wardbell

Copy link
Copy Markdown
Contributor

LGTM. Merging.

@wardbell
wardbell merged commit 738b550 into angular:master Jul 20, 2016
@wardbell
wardbell deleted the chalin-dart-tut-misc-fixes-0720 branch July 20, 2016 17:01
@kwalrath

Copy link
Copy Markdown
Contributor

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dart][example] tutorial/toh-4: styles look wrong

5 participants