This repository was archived by the owner on Dec 4, 2017. It is now read-only.
Conversation
6 tasks
Contributor
Author
|
@kwalrath @wardbell @Foxandxss : ready for review. |
chalin
force-pushed
the
chalin-toh-1-e2e-0608
branch
2 times, most recently
from
June 8, 2016 22:56
a686819 to
87e95ce
Compare
Contributes to angular#1619.
chalin
force-pushed
the
chalin-toh-1-e2e-0608
branch
from
June 13, 2016 14:16
87e95ce to
1fc3592
Compare
Contributor
|
Closed by 59408b1 |
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jun 29, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. 3 minor bugs were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jun 29, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. **3 minor bugs** were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jun 30, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. **3 minor bugs** were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jul 1, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. **3 minor bugs** were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jul 1, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. **3 minor bugs** were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jul 2, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. **3 minor bugs** were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jul 3, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. **3 minor bugs** were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jul 4, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. **3 minor bugs** were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jul 6, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. **3 minor bugs** were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jul 8, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. **3 minor bugs** were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jul 12, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. **3 minor bugs** were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jul 12, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. **3 minor bugs** were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jul 15, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. **3 minor bugs** were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jul 17, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. **3 minor bugs** were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
chalin
added a commit
to chalin/angular.io
that referenced
this pull request
Jul 20, 2016
From the user's perspective toh-2 to -4 all have the same behavior. This PR introduces e2e tests for all these parts by sharing test suites. **3 minor bugs** were detected by the tests and are fixed in this PR. The toh-1 tests introduced in angular#1620 are - Refactored so as to be easier to reuse for the other parts. - Rewritten to benefit from the availability of async/await. Suites passed: - public/docs/_examples/toh-1/dart - public/docs/_examples/toh-1/ts - public/docs/_examples/toh-2/dart - public/docs/_examples/toh-2/ts - public/docs/_examples/toh-3/dart - public/docs/_examples/toh-3/ts - public/docs/_examples/toh-4/dart - public/docs/_examples/toh-4/ts Contributes to angular#1619. Fixes angular#1609. Now the toh-4 index.html is identical to those of the previous parts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #1619.