feat(@angular/cli): read proxyConfig from angular-cli.json

[ayvazj]

easy proxy config by reading default from angular-cli.json (#6240)

[filipesilva]

LGTM overall, just a few minor changes to ensure everything is consistent. Good work!

[filipesilva]

Can you remove the default here? It's better to not have one since sending in an empty string is different than not sending anything.

[filipesilva]

Can you rename the proxy.ts test to proxy-config.ts, and do all tests in a single file using the --proxy-config flag? I think we must have renamed the flag at one point and forgot to change the test name.

[ayvazj]

updated - let me know if I missed anything. Thanks.

[filipesilva]

The tests seem to be failing, there might be something broken in the new set of changes.

[ayvazj]

tests are failing for me because the command @angular/cli is keeping a port open. Could it be that killAllProcesses is not working? The tree-kill node module is using pgrep -P PID on macOS which does not work, but ps ax does.

> sudo lsof -t -i:4200           
32159
> pgrep -P 32159
> ps -a 32159
PID TTY           TIME CMD
32159 ttys000    3:33.14 @angular/cli

Is this a known issue?

[filipesilva]

@ayvazj I'm not sure what's keeping the port open on the revised test, but am reasonably sure killAllProcesses is working since we have a lot of tests that use it.

It might be that you can't do .then(() => expectToFail(() => ngServe())); at the end and need to do .then(() => expectToFail(() => ng('serve')) instead, since ngServe() is waiting to match some output.

[ayvazj]

@filipesilva got some time to revisit this. my bad, I wasn't opening/closing the server properly after consolidating tests, causing downstream tests to fail.

[filipesilva]

@ayvazj thanks for updating it, there's a test failing but I think it's a fluke so restarted the CI run. Cheers!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}