Skip to content

build(@angular/cli): update sourcemap-istanbul-instrumenter-loader - #4560

Merged
hansl merged 3 commits into
angular:masterfrom
filipesilva:update-instanbul-instrumenter-license
Feb 9, 2017
Merged

hansl merged 3 commits into
angular:masterfrom
filipesilva:update-instanbul-instrumenter-license

Conversation

@filipesilva

@filipesilva filipesilva commented Feb 9, 2017 •

Copy link
Copy Markdown
Contributor

Thanks to @deepsweet for the license update!

Followup from webpack-contrib/istanbul-instrumenter-loader#39
Partially address #3884

BREAKING CHANGE:

The default LCOV file is now coverage/lcov.info instead of coverage/coverage.lcov.

ng test --code-coverage now uses karma-coverage-istanbul-reporter instead of karma-remap-istanbul.

To update follow these steps in your project:

  • npm uninstall karma-remap-istanbul
  • npm install karma-coverage-istanbul-reporter

Then copy karma.conf.js from a new project, or update it manually:

  • replace require('karma-remap-istanbul'), with require('karma-coverage-istanbul-reporter'),
  • replace ['progress', 'karma-remap-istanbul'] with ['progress', 'coverage-istanbul']
  • replace
    remapIstanbulReporter: {
      reports: {
        html: 'coverage',
        lcovonly: './coverage/coverage.lcov'
      }
    },

with

    coverageIstanbulReporter: {
      reports: [ 'html', 'lcovonly' ],
      fixWebpackSourcePaths: true
    },

@filipesilva
filipesilva requested review from Brocco and hansl February 9, 2017 13:34
@filipesilva
filipesilva force-pushed the update-instanbul-instrumenter-license branch 2 times, most recently from cf0352e to 549d589 Compare February 9, 2017 16:04
@filipesilva
filipesilva force-pushed the update-instanbul-instrumenter-license branch from 549d589 to 47c257f Compare February 9, 2017 16:05

@hansl hansl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

@hansl
hansl merged commit 15b6d9c into angular:master Feb 9, 2017
@filipesilva
filipesilva deleted the update-instanbul-instrumenter-license branch February 10, 2017 10:38
filipesilva added a commit that referenced this pull request Feb 10, 2017
filipesilva added a commit that referenced this pull request Feb 10, 2017
hansl pushed a commit that referenced this pull request Feb 12, 2017
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants