Skip to content

build: do not do a full build _after_ we have done an incremental one. - #416

Merged
hansl merged 1 commit into
angular:masterfrom
hansl:compiler-fix
Apr 11, 2016
Merged

build: do not do a full build _after_ we have done an incremental one.#416
hansl merged 1 commit into
angular:masterfrom
hansl:compiler-fix

Conversation

@hansl

@hansl hansl commented Apr 10, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@jkuri

jkuri commented Apr 10, 2016

Copy link
Copy Markdown
Contributor

👍 Can you rebase please?
Also, can you merge _doIncrementalBuild() and _doFullBuild() into one method, seems like some of the code is duplicated?

@jkuri

jkuri commented Apr 10, 2016

Copy link
Copy Markdown
Contributor

Or just use _collectErrors in the _doFullBuild(). If this is something that is going to be done in the future its okay. This fix is actually what we need for now, thanks.

@hansl

hansl commented Apr 10, 2016

Copy link
Copy Markdown
Contributor Author

Done.

jkuri
jkuri reviewed Apr 10, 2016
View reviewed changes
Comment thread lib/broccoli/broccoli-typescript.js Outdated
this._createServiceHost();
this._doFullBuild();
} else {
// this._doFullBuild();

@jkuri jkuri Apr 10, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a note for you for the future work? You could also remove the whole method since its not used :-)

@hansl hansl Apr 10, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that was a test to see if we really needed it, apparently not.

@jkuri

jkuri commented Apr 11, 2016

Copy link
Copy Markdown
Contributor

LGTM 👍

@hansl
hansl merged commit af5dbef into angular:master Apr 11, 2016
@hansl
hansl deleted the compiler-fix branch April 11, 2016 00:06
@jkuri jkuri mentioned this pull request Apr 11, 2016
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 9, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hansl @jkuri