Repository navigation
Conversation
Contributor
|
@dhcdata thank you for taking the time to do this PR, but the approach in #3392 is better for this problem. While it is true that just not removing the CNAME file would work, the reason why the 404 and gitignore files are kept is they are part of the deploy process and generated by it. I think it's better to have the flag explicitly than to have an extra file. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The approach to support custom domains in #3392 would require providing the --custom-domain flag on every deploy. That's a fine approach. Alternatively, github-pages:deploy could simply not remove an existing CNAME. This PR takes the latter approach while beginning to pull the guarded file names into a variable that could perhaps be defined within the angular-cli.json at some point.