Skip to content

Add documentation on how to use a custom domain - #3881

Closed
dhcdata wants to merge 1 commit into
angular:masterfrom
dhcdata:patch-1
Closed

dhcdata wants to merge 1 commit into
angular:masterfrom
dhcdata:patch-1

Conversation

@dhcdata

@dhcdata dhcdata commented Jan 6, 2017

Copy link
Copy Markdown

No description provided.

@hansl

hansl commented Jan 6, 2017

Copy link
Copy Markdown
Contributor

That is not our documentation format at all. If you're interested in doing the right change, you should add the argument documentation to the /docs/wiki folder in the project, which contains all our documentation.

@dhcdata

dhcdata commented Jan 6, 2017 •

Copy link
Copy Markdown
Author

I would gladly put it where ever it belongs in the correct format if you could point to any documentation on formatting.

There is no /docs/wiki folder in the project. There is a /docs/documentation and a /docs/design.

I didn't think to put it in either of those places since github-pages:deploy command isn't documented there at all. This command is also not documented to the wiki attached to the project. This command is however documented on the /README.md page.

@hansl

hansl commented Jan 10, 2017

Copy link
Copy Markdown
Contributor

/docs/documentation is what I meant. github-pages:deploy should be documented in there since we officially support it.

@austingreendev

Copy link
Copy Markdown
Contributor

@dhcdata my pull-request #3392 introduces a --custom-domain flag which handles the base-href manipulation and CNAME file creation. Your additions look good, but I would suggest using that new flag. Thanks!

@dhcdata dhcdata closed this Jan 13, 2017
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants