Repository navigation
fix(build): fix path error when appConfig has no main - #3867
Merged
Merged
Conversation
filipesilva
force-pushed
the
no-main-no-fail
branch
from
January 6, 2017 00:01
7e20b51 to
444a2e5
Compare
Contributor
|
From what I understand this also allows people to use the CLI for apps that have no main at all, correct? |
Contributor
Author
|
@hansl yes, it will simply compile |
hansl
suggested changes
Jan 10, 2017
| }] | ||
| }), | ||
| })) | ||
| .then(() => ng('build')); |
Contributor
There was a problem hiding this comment.
Could you verify that console.log('hello') is in the output? Alternatively, does ng serve still work? I'd rather test that.
filipesilva
force-pushed
the
no-main-no-fail
branch
2 times, most recently
from
January 11, 2017 12:57
f5251e3 to
ec0a1df
Compare
filipesilva
force-pushed
the
no-main-no-fail
branch
from
January 11, 2017 13:35
ec0a1df to
d07dbcb
Compare
Contributor
|
LGTM. |
hansl
approved these changes
Jan 11, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a path error when
mainis missing inangular-cli.json: