Skip to content

refactor(serve): remove unused option baseURL - #3856

Closed
mham wants to merge 1 commit into
angular:masterfrom
mham:issue-3531
Closed

mham wants to merge 1 commit into
angular:masterfrom
mham:issue-3531

Conversation

@mham

@mham mham commented Jan 4, 2017

Copy link
Copy Markdown
Contributor

Fixes #3531

@hansl

hansl commented Jan 10, 2017

Copy link
Copy Markdown
Contributor

This doesn't seem like it's fixing the issue you're pointing at. And also baseUrl is actually used.

I think the bug is subtler than this; we don't reuse commandOptions when assigning it, so it gets overwritten.

In any case, I'd like to have an e2e test that creates an invalid config/environment.js file (just throw an error) and tries to build and serve. This way at least we're sure that the environment isn't taken into account anymore.

@hansl
hansl self-requested a review January 10, 2017 22:57
@filipesilva

Copy link
Copy Markdown
Contributor

Superseded by #4057, which is the real fix.

@mham
mham deleted the issue-3531 branch February 20, 2017 19:13
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ERROR when using 'ng serve' with a ./config/environment.js path

4 participants