Skip to content

chore(install): move ember cli in our repo and remove everything unne… - #3056

Merged
hansl merged 3 commits into
angular:masterfrom
hansl:ember-gutting
Nov 10, 2016
Merged

hansl merged 3 commits into
angular:masterfrom
hansl:ember-gutting

Conversation

@hansl

@hansl hansl commented Nov 8, 2016

Copy link
Copy Markdown
Contributor

…cessary

More packages might be necessary. Turns out they have other ember dependencies that are taking a while to install..

@hansl
hansl force-pushed the ember-gutting branch 7 times, most recently from 703ba9c to af56633 Compare November 9, 2016 03:12
@hansl
hansl force-pushed the ember-gutting branch 4 times, most recently from 3c87eff to 59c0f63 Compare November 9, 2016 23:46
@hansl
hansl merged commit 28925dc into angular:master Nov 10, 2016
@hansl
hansl deleted the ember-gutting branch November 10, 2016 01:35
@JohannesHoppe

Copy link
Copy Markdown
Contributor

Guys, whatever you do, please keep the plugin loader logic!
And if you are already working on this, rename the "magic" keyoword ember-addon to angular-addon. Thanks! 👍

see e.g. angular-schule/angular-cli-ghpages#1

MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
…cessary (angular#3056)

* chore(install): move ember-cli to a directory in angular-cli
* further remove files
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants