Skip to content

fix(generate): show error when no name is specified - #2684

Closed
Puigcerber wants to merge 1 commit into
angular:masterfrom
Puigcerber:no-name-error
Closed

Puigcerber wants to merge 1 commit into
angular:masterfrom
Puigcerber:no-name-error

Conversation

@Puigcerber

Copy link
Copy Markdown
Contributor

Show custom error when user forgets the name while generating blueprints.
Earlier it would fall to the dynamicPathParser function and throw a TypeError: Path must be a string. Received undefined.

I think it wouldn't make sense to add the same test to all the generate-*.spec.js files, but not sure if generate-module.spec.js is the best place either.

Show custom error when user forgets the name while generating blueprints.
Earlier it would fall to the dynamicPathParser function and throw a TypeError: Path must be a string. Received undefined.

@filipesilva filipesilva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Brocco pushed a commit that referenced this pull request Oct 19, 2016
Show custom error when user forgets the name while generating blueprints.
Earlier it would fall to the dynamicPathParser function and throw a TypeError: Path must be a string. Received undefined.

Close #2684
kieronqtran pushed a commit to kieronqtran/angular-cli that referenced this pull request Oct 21, 2016
Show custom error when user forgets the name while generating blueprints.
Earlier it would fall to the dynamicPathParser function and throw a TypeError: Path must be a string. Received undefined.

Close angular#2684
texel pushed a commit to splice/angular-cli that referenced this pull request Nov 3, 2016
Show custom error when user forgets the name while generating blueprints.
Earlier it would fall to the dynamicPathParser function and throw a TypeError: Path must be a string. Received undefined.

Close angular#2684
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 10, 2019
mostafaibr pushed a commit to mostafaibr/angular-cli that referenced this pull request May 29, 2026
Show custom error when user forgets the name while generating blueprints.
Earlier it would fall to the dynamicPathParser function and throw a TypeError: Path must be a string. Received undefined.

Close angular#2684
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants