Skip to content

chore(build): remove tslint options #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filipesilva wants to merge 1 commit into from
Closed

chore(build): remove tslint options #2616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions packages/angular-cli/models/webpack-build-development.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,5 @@
const path = require('path');

import * as webpack from 'webpack';

declare module 'webpack' {
export interface LoaderOptionsPlugin {}
export interface LoaderOptionsPluginStatic {
new (optionsObject: any): LoaderOptionsPlugin;
}
interface Webpack {
LoaderOptionsPlugin: LoaderOptionsPluginStatic;
}
};

export const getWebpackDevConfigPartial = function(projectRoot: string, appConfig: any) {
return {
devtool: 'source-map',
Expand All @@ -21,17 +9,6 @@ export const getWebpackDevConfigPartial = function(projectRoot: string, appConfi
sourceMapFilename: '[name].map',
chunkFilename: '[id].chunk.js'
},
plugins: [
new webpack.LoaderOptionsPlugin({
options: {
tslint: {
emitErrors: false,
failOnHint: false,
resourcePath: path.resolve(projectRoot, appConfig.root)
},
}
})
],
node: {
fs: 'empty',
global: true,
Expand Down
15 changes: 10 additions & 5 deletions packages/angular-cli/models/webpack-build-production.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,16 @@ const WebpackMd5Hash = require('webpack-md5-hash');
const CompressionPlugin = require('compression-webpack-plugin');
import * as webpack from 'webpack';

declare module 'webpack' {
export interface LoaderOptionsPlugin {}
export interface LoaderOptionsPluginStatic {
new (optionsObject: any): LoaderOptionsPlugin;
}
interface Webpack {
LoaderOptionsPlugin: LoaderOptionsPluginStatic;
}
}

export const getWebpackProdConfigPartial = function(projectRoot: string, appConfig: any) {
return {
devtool: 'source-map',
Expand All @@ -27,11 +37,6 @@ export const getWebpackProdConfigPartial = function(projectRoot: string, appConf
}),
new webpack.LoaderOptionsPlugin({
options: {
tslint: {
emitErrors: true,
failOnHint: true,
resourcePath: path.resolve(projectRoot, appConfig.root)
},
htmlLoader: {
minimize: true,
removeAttributeQuotes: false,
Expand Down