Skip to content

fix(@angular-devkit/build-angular): show --disable-host-check warning only when not using disableHostCheck - #20952

Merged
clydin merged 1 commit into
angular:masterfrom
alan-agius4:host-check-warning
May 26, 2021
Merged

clydin merged 1 commit into
angular:masterfrom
alan-agius4:host-check-warning

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

Closes #20951

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label May 26, 2021
@alan-agius4
alan-agius4 requested a review from clydin May 26, 2021 11:12
@google-cla google-cla Bot added the cla: yes label May 26, 2021
Comment thread packages/angular_devkit/build_angular/src/dev-server/index.ts Outdated
…ng only when not using `disableHostCheck`

Closes #20951
@alan-agius4
alan-agius4 requested a review from clydin May 26, 2021 15:04
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 26, 2021
@clydin
clydin merged commit 7ff41e4 into angular:master May 26, 2021
@alan-agius4
alan-agius4 deleted the host-check-warning branch May 26, 2021 18:18
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular 9 --disableHostCheck flag has no effect when --host is passed (or --configuration)

2 participants