Skip to content

fix(@ngtools/webpack): add Webpack 5 to peer dependencies - #18847

Closed
valorkin wants to merge 1 commit into
angular:masterfrom
valorkin:chore-ngtools-webpack-dep
Closed

valorkin wants to merge 1 commit into
angular:masterfrom
valorkin:chore-ngtools-webpack-dep

Conversation

@valorkin

Copy link
Copy Markdown
Contributor

Very minor addition to #18820
adding optional webpack@5 to peer dependencies of ngtools/webpack

@valorkin
valorkin force-pushed the chore-ngtools-webpack-dep branch from e99fc4d to 6d8d63d Compare September 22, 2020 12:22
Comment thread packages/ngtools/webpack/package.json Outdated
"@angular/compiler-cli": "^11.0.0 || ^11.0.0-next",
"typescript": ">=3.9 < 4.1",
"webpack": "^4.0.0"
"webpack": "^4.0.0 || ^5.0.0"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webpack version 5 is not yet stable thus the semver version here is invalid. It should be ^5.0.0-rc.0.

Chiming in @clydin just to confirm whether we should add this peerDependencies in the first place since Webpack 5 support is still experimental, and adding Webpack 5 might send out the wrong message.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: chore is an invalid commit message type. You can use fix for this.

fix(@ngtools/webpack): add Webpack 5 to peer dependencies

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, just made it the same way as it appears in all other occurrences. I can change those to rc.0 too

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all comments applied

@valorkin
valorkin force-pushed the chore-ngtools-webpack-dep branch from 6d8d63d to 665e999 Compare September 22, 2020 12:31
@alan-agius4
alan-agius4 requested a review from clydin September 22, 2020 12:32
@valorkin valorkin changed the title chore(@ngtools/webpack): minor fix to dependency to support ^5 fix(@ngtools/webpack): minor fix to dependency to support ^5 Sep 22, 2020
@valorkin
valorkin force-pushed the chore-ngtools-webpack-dep branch from 665e999 to 878ebc1 Compare September 22, 2020 12:44
@valorkin valorkin changed the title fix(@ngtools/webpack): minor fix to dependency to support ^5 fix(@ngtools/webpack): add Webpack 5 to peer dependencies Sep 22, 2020
@clydin

clydin commented Feb 17, 2021

Copy link
Copy Markdown
Member

Thank you for the contribution.
However, this has been superseded by #20037.

@clydin clydin closed this Feb 17, 2021
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants