Repository navigation
feat(@angular-devkit/build-angular): auto configure hot module replacement (HMR) - #18788
Merged
Merged
Conversation
alan-agius4
changed the title
alan-agius4
added
target: major
alan-agius4
marked this pull request as ready for review
September 17, 2020 10:34
alan-agius4
added
the
needs: discussion
clydin
reviewed
Sep 24, 2020
clydin
reviewed
Sep 24, 2020
clydin
approved these changes
Sep 24, 2020
alan-agius4
removed
the
needs: discussion
kyliau
reviewed
Sep 24, 2020
dgp1130
reviewed
Sep 24, 2020
|
|
||
| function restoreFormValues(oldInputs, oldOptions) { | ||
| // Restore input | ||
| const newInputs = document.querySelectorAll('input'); |
Collaborator
There was a problem hiding this comment.
What about shadow roots? I don't think this would pick up input elements hidden under a shadow root, though I don't know how commonly those are used in Angular applications.
Collaborator
Author
There was a problem hiding this comment.
I don't think it's that common, I don't want to add complexity and use-cases to support just for the sake of it. I think we can evaluate shadow root based on the community feedback.
Collaborator
There was a problem hiding this comment.
I'm fine to defer it, though we may want to document that limitation somewhere.
…ement (HMR) With this change we configure HMR internally and therefore users which want to use basic HMR functionality will not longer be required to change their application code. This is important because previously a lot of users missed out on HMR or reported a broken behaviour. This also gives novice users a better chance to appreciate HMR and Angular because of the zero effort required to use HMR. Closes #17324
kyliau
approved these changes
Sep 25, 2020
dgp1130
approved these changes
Sep 25, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we configure HMR internally and therefore users which want to use basic HMR functionality will not longer be required to change their application code.
This is important because previously a lot of users missed out on HMR or reported a broken behaviour. This also gives novice/new users a better chance to appreciate HMR and Angular because of the zero effort required to use HMR.
Closes #17324