Skip to content

ci: update ignore_pull_requests to only include release-able branches - #16703

Merged
dgp1130 merged 1 commit into
angular:masterfrom
alan-agius4:circle-ignore-pr
Jan 21, 2020
Merged

dgp1130 merged 1 commit into
angular:masterfrom
alan-agius4:circle-ignore-pr

Conversation

@alan-agius4

Copy link
Copy Markdown
Collaborator

Currently certain steps like e2e-cli-node-10 and snapshot_publish are being run for PRs which are created via non forked repos. Such as renovate and users who create PRs directly from github via Edit file.

Example of such branch names are;

renovate/sass-loader
alan-agius4-testing-branch

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 18, 2020
@alan-agius4
alan-agius4 requested a review from clydin January 18, 2020 11:18

@clydin clydin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe change the name to “only_release_branches”?

Currently certain steps like `e2e-cli-node-10` and `snapshot_publish` are being run for PRs which are created via non forked repos. Such as renovate and users who create PRs directly from github via `Edit file`.

Example of such branch names are;

```
renovate/sass-loader
alan-agius4-testing-branch
```
@dgp1130
dgp1130 merged commit 7a06f41 into angular:master Jan 21, 2020
@alan-agius4
alan-agius4 deleted the circle-ignore-pr branch January 21, 2020 16:35
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants