Skip to content

fix(@schematics/angular): add CanDeactivate guard - #16195

Merged
dgp1130 merged 1 commit into
angular:masterfrom
cexbrayat:fix/15668-can-deactivate
Nov 14, 2019
Merged

dgp1130 merged 1 commit into
angular:masterfrom
cexbrayat:fix/15668-can-deactivate

Conversation

@cexbrayat

@cexbrayat cexbrayat commented Nov 14, 2019 •

Copy link
Copy Markdown
Member

This generates a generic CanDeactivate<unknown> guard.

Fixes #15668

Comment thread packages/schematics/angular/guard/index.ts Outdated
This generates a generic `CanDeactivate<unknown>` guard.

Fixes angular#15668
@cexbrayat
cexbrayat force-pushed the fix/15668-can-deactivate branch from e59368e to 2a53e03 Compare November 14, 2019 15:21
@cexbrayat
cexbrayat requested a review from clydin November 14, 2019 15:21
@clydin clydin added the target: patch This PR is targeted for the next patch release label Nov 14, 2019
@dgp1130
dgp1130 merged commit 2fc3fab into angular:master Nov 14, 2019
@dgp1130

dgp1130 commented Nov 14, 2019

Copy link
Copy Markdown
Collaborator

Merged to 9.0.x patch: https://github.com/angular/angular-cli/commits/9.0.x.

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to implement CanDeactivate interface while generating a guard

4 participants