Skip to content

Added README.md and added eclipse workspace stuff to .gitignore - #1035

Closed
reflexdemon wants to merge 2 commits into
angular:masterfrom
reflexdemon:master
Closed

reflexdemon wants to merge 2 commits into
angular:masterfrom
reflexdemon:master

Conversation

@reflexdemon

Copy link
Copy Markdown
Contributor

@filipesilva
Here is the PR for #935 and has the following

  1. Include README.md file part of generated source
  2. Added Eclipse workspace files to the .gitignore on the generated source.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@reflexdemon

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@reflexdemon

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

filipesilva pushed a commit to filipesilva/angular-cli that referenced this pull request Jun 13, 2016
filipesilva pushed a commit that referenced this pull request Jun 13, 2016
@filipesilva

Copy link
Copy Markdown
Contributor

Sorry that I took so long to get to this PR. I merged it in but changed some parts of it. I shortened the readme and added the github deploy section.

I also removed a lot of the files you put in gitignore - I know it was the official gitignore for eclipse projects but a lot of those entries were only applicable for projects mixing javascript and something else. I tried to leave only the bare essential ignores for eclipse.

Thanks for taking the time to help out!

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants