Skip to content

Barrel exports should be alphabetized #582

Closed

Description

@johnpapa

Minor nit

can we alphabetize them?

export * from './entity.service';
export * from './exception.service';
export * from './init-caps.pipe';
export * from './message.service';
export * from './config';
export * from './toast';
export * from './toast/toast.service';
export * from './spinner';
export * from './spinner/spinner.service';
export * from './speaker.service';
export * from './speaker.model';
export * from './nav';
export * from './modal';
export * from './modal/modal.service';
export * from './filter-text';
export * from './filter-text/filter-text.service';

cc @Brocco

Activity

  1. self-assigned this
    on May 1, 2016
  2. added 3 commits that reference this issue on May 13, 2016
    26a0cb8
    70433e8
    0754847
  3. added a commit that references this issue on May 28, 2016
    67b577d
  4. Blasz commented on Jun 24, 2016

    @Blasz

    Won't specific barrel ordering be required when any of the exports depend on each other to prevent circular dependencies? Making them alphabetised may break this. angular/angular#9334

  5. angular-automatic-lock-bot commented on Sep 5, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  6. locked and limited conversation to collaborators on Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions