You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Continued use of ember-addon package.json keyword poised to cause trouble #55
There's only a single angular addon listed, but I moved my app over to angular-cli today partly to start packaging some of my code as addons. So I anticipate that changing.
changed the title [-]Continued use of `ember-addon` package.json key poised to cause trouble[/-][+]Continued use of `ember-addon` package.json keyword poised to cause trouble[/+]on Oct 25, 2015
yup. I know about this one. my plan is to talk to @stefanpenner about this and see if we can do better.
To be honest I don't think that the current strategy of creating angular-cli as an addon for ember-cli will work beyond tech demo. There way too many assumption in the current system. The only way I can see this working is for us to extract all the reusable bits from ember-cli into a separate project and then build both angular and ember cli on top of this project. The alternative is to rebuild most of the current stuff from scratch, but that would be sad.
I'm going to close this issue as this discussion seems to be closed. Once we hit alpha we need to revisit our long term plans with @stefanpenner and see how we can help make both projects better (and awesome-er)
Activity
[-]Continued use of `ember-addon` package.json key poised to cause trouble[/-][+]Continued use of `ember-addon` package.json keyword poised to cause trouble[/+]cironunes commentedon Oct 26, 2015
This is being addressed here IgorMinar/angular-cli-github-pages#1
The actual issue is on the angular-cli-github-pages project.
endash commentedon Oct 26, 2015
Except that https://github.com/ember-cli/ember-cli/blob/ae5e72614e40f5e6dd57463e526c65da899fde07/lib/models/addon-discovery.js#L206 will result in the addon not being discovered.
IgorMinar commentedon Nov 23, 2015
yup. I know about this one. my plan is to talk to @stefanpenner about this and see if we can do better.
To be honest I don't think that the current strategy of creating angular-cli as an addon for ember-cli will work beyond tech demo. There way too many assumption in the current system. The only way I can see this working is for us to extract all the reusable bits from ember-cli into a separate project and then build both angular and ember cli on top of this project. The alternative is to rebuild most of the current stuff from scratch, but that would be sad.
stefanpenner commentedon Nov 23, 2015
Im in-board with further parametrization/extraction/configuration as needed. We just need extra people power :) and a plan
cironunes commentedon Nov 23, 2015
I'd love to help.
hansl commentedon Mar 17, 2016
I'm going to close this issue as this discussion seems to be closed. Once we hit alpha we need to revisit our long term plans with @stefanpenner and see how we can help make both projects better (and awesome-er)
docs(@schematics/angular): update url in docs
angular-automatic-lock-bot commentedon Sep 5, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.